Feature Request: Custom File Extension Filter For Code Review #8958
Unanswered
barnesew
asked this question in
Pull Requests
Replies: 1 comment
-
@barnesew, I just learned that I can add a https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
General
Hello. I've been running into a small annoyance while participating in code reviews and I think a simple improvement could be made to help me and others who have a similar situation.
Problem
We use a lot of code generation in our repository and we like to have it tracked in source control. Each of the files has a file naming convention of "*.gen.ext". Whenever we make a PR to start a code review, we have no way to filter by the sub-extension; Only direct extensions are present in the file filter dropdown (*.ts, *.js, *.html, etc.) as seen here:
Since we don't want to view the generated files, it would be nice to have a way to filter them out during reviews.
Possible Solution
One possible solution could be to allow for a custom file filter in the dropdown where users can specify a wildcard filter kind of like how VSCode handles a global search:
Another possible solution could be to include sub-extensions in the filter options such as *.gen.ts. Since there would be overlap between the sub-extensions and the actual file extensions, this sounds like a less desirable solution.
Beta Was this translation helpful? Give feedback.
All reactions