Github Copilot Extension API Sending Invalid JSON

[andrewlayer]

The Github copilot extensions API returns invalid JSON. When a new chat is created, a new message has been prepended to the chat with the "name" field _session. This contains invalid JSON when intercepted by a server. Here is an example of the invalid JSON that is received from Github.

{
    "copilot_thread_id": "5b4c43f4-6291-43b7-a800-261b053c013d",
    "messages": [
        {
            "role": "user",
            "content": "Current Date and Time (UTC): 2024-11-12 16:01:37\\nCurrent User\'s Login: user\\n",  <---- INVALID escape character
            "name": "_session",
            "copilot_references": [
                {
                    "type": "github.redacted",
                    "data": {
                        "type": "github.current-url"
                    },
                    "id": "fe41cb1f-4d4c-40e5-8c19-5e35b40214f2",
                    "is_implicit": true,
                    "metadata": {
                        "display_name": "",
                        "display_icon": "",
                        "display_url": ""
                    }
                }
            ],
            "copilot_confirmations": null
        },
        {
            "role": "user",
            "content": "",
            "copilot_references": [
                {
                    "type": "github.redacted",
                    "data": {
                        "type": "github.repository"
                    },
                    "id": "1aa1249c-aadb-4a47-a36c-bb8086b95dd7",
                    "is_implicit": false,
                    "metadata": {
                        "display_name": "",
                        "display_icon": "",
                        "display_url": ""
                    }
                }
            ],
            "copilot_confirmations": null
        },
        {
            "role": "user",
            "content": "hello",
            "copilot_references": [],
            "copilot_confirmations": []
        }
    ],
}

Please let me know if you need more details.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[GavynWithLayer]

Yes, noticed this as well. I know some parsers allow escaped single-quotes like this, but I believe it goes against the JSON spec.

https://www.json.org/json-en.html#:~:text=A%20string%20is%20a%20sequence%20of%20zero%20or%20more%20Unicode%20characters%2C%20wrapped%20in%20double%20quotes%2C%20using%20backslash%20escapes.%20A%20character%20is%20represented%20as%20a%20single%20character%20string.%20A%20string%20is%20very%20much%20like%20a%20C%20or%20Java%20string.

[munasrr]

It appears there's an issue in the JSON formatting due to the use of double backslashes (\n) for newline characters. In JSON, newline characters should be represented as a single backslash followed by n (\n).

[GavynWithLayer]

I don't believe this is it, it's the escaped single quote causing the issue (which is not in spec with JSON).

[munasrr]

oh i see here "Current Date and Time (UTC): 2024-11-12 16:01:37\nCurrent User's Login: user\n", check where your saying nCurrent User/'s and change it to User's / your using / in a wrong place hope this helps you