Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When loaded within an iframe the cookie settings are not stored #766

Closed
joshf opened this issue Jan 6, 2025 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@joshf
Copy link

joshf commented Jan 6, 2025

Expected Behavior

When the plugin loaded in an iframe the settings should be stored.

Current Behavior

When you use the plugin on a page which is loaded in an iframe, the settings are not stored so the prompt show every time

Steps to reproduce

https://codesandbox.io/p/sandbox/rjk9n4zj7m (https://kp3d29.csb.app/)

it is embedding this one:

https://codesandbox.io/p/sandbox/334dh4

Proposed fix or additional info.

No response

Version

3.0.1

On which browser do you see the issue?

Chrome

@joshf joshf added the bug Something isn't working label Jan 6, 2025
@github-actions github-actions bot added the triage yet to be reviewed label Jan 6, 2025
@orestbida orestbida removed the triage yet to be reviewed label Jan 16, 2025
@orestbida
Copy link
Owner

It is working fine on my end. Once I have accepted/rejected the plugin inside the modal, it no longer appears on subsequent reloads (unless I manually open the original page and delete the cookie).

@joshf
Copy link
Author

joshf commented Jan 16, 2025

I realise now it is because of the setting in chrome to block third party cookies which seems to be the default now

@joshf joshf closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants