You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
I'm currently making a Rust port of IPFS log, and I noticed that the docstring return values in log-sorting.js are incorrect:
It is claimed @returns {number} 1 if a is greater, -1 if b is greater when actually it is the other way around.
SortByClocks is claimed to return 1 or -1 (in the manner stated above), but in reality it returns the time difference between the two clocks, which can potentially be any signed integer. (Naturally and fortunately though, this doesn't affect its behavior as a sorting compare function, which it is used as.)
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm currently making a Rust port of IPFS log, and I noticed that the docstring return values in log-sorting.js are incorrect:
The text was updated successfully, but these errors were encountered: