Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enabling CA2007 rule to require ConfigureAwait(false) on all awaited tasks #168

Closed
1 task done
leonardochaia opened this issue Nov 26, 2024 · 1 comment · Fixed by #170
Closed
1 task done
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@leonardochaia
Copy link
Contributor

What is the version or commit of the ORAS .NET library?

No response

What would you like to be added?

I would like the .editorconfig to be modified to include the CA2007 rule, which requires awaited tasks to have ConfigureAwait(false)

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2007

Why is this needed for the ORAS .NET library?

This would make reviewing PRs easier since we, as a library, must ConfigureAwait(false) everywhere.

Sample PR implementing such changes:
dotnet/aspnetcore#39946

Confirm we want it and I'll create the PR 👍

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@leonardochaia leonardochaia added enhancement New feature or request triage New issues or PRs to be acknowledged by maintainers labels Nov 26, 2024
@leonardochaia leonardochaia changed the title Consider enabling CA2007 Consider enabling CA2007 rule to require ConfigureAwait(false) on all awaited tasks Nov 26, 2024
@shizhMSFT shizhMSFT removed the triage New issues or PRs to be acknowledged by maintainers label Nov 27, 2024
@shizhMSFT
Copy link
Contributor

This is a good idea. Let's have a try.

@shizhMSFT shizhMSFT added this to the v0.3.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants