Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(referrers): push manifest with subject #163

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat(referrers): push manifest with subject #163

wants to merge 20 commits into from

Conversation

pat-pan
Copy link
Contributor

@pat-pan pat-pan commented Nov 19, 2024 •
edited
Loading

What this PR does / why we need it

The PR is to implement the feature to push manifest with subject as per the OCI distribution spec v1.1.0.

Which issue(s) this PR resolves / fixes

Resolves / Fixes #159

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Patrick Pan added 2 commits November 18, 2024 18:16
push manifest with subject
e3e1217 
Signed-off-by: Patrick Pan <[email protected]>
add unit tests
846e173 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan changed the title feature: push manifest with subject feature(referrers): push manifest with subject Nov 19, 2024
add unit tests
7fca0cb 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 952a63a to 7fca0cb Compare November 19, 2024 07:10
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from bd14c4d to edc79f5 Compare November 19, 2024 07:25
resolve merge conflicts
7809549 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from edc79f5 to 7809549 Compare November 19, 2024 07:26
add tests
c7e4418 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from e380c12 to c7e4418 Compare November 19, 2024 07:34
@shizhMSFT shizhMSFT changed the title feature(referrers): push manifest with subject feat(referrers): push manifest with subject Nov 19, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.01124% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (a9103d2) to head (c30d6b2).

Files with missing lines Patch % Lines
.../OrasProject.Oras/Registry/Remote/ManifestStore.cs 87.17% 3 Missing and 7 partials ⚠️
src/OrasProject.Oras/Registry/Remote/Referrers.cs 88.88% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   81.70%   82.96%   +1.26%     
==========================================
  Files          35       37       +2     
  Lines        1104     1280     +176     
  Branches      127      152      +25     
==========================================
+ Hits          902     1062     +160     
- Misses        146      153       +7     
- Partials       56       65       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Patrick Pan added 3 commits November 20, 2024 09:21
add comments
a6d552f 
Signed-off-by: Patrick Pan <[email protected]>
add unit test
685ab70 
Signed-off-by: Patrick Pan <[email protected]>
add unit tests
1b9ade3 
Signed-off-by: Patrick Pan <[email protected]>
Wwwsylvia
Wwwsylvia requested changes Nov 20, 2024
View reviewed changes
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/HttpResponseMessageExtensions.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/HttpResponseMessageExtensions.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/HttpResponseMessageExtensions.cs Show resolved Hide resolved
src/OrasProject.Oras/Oci/Index.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Index.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/RepositoryOptions.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/RepositoryOptions.cs Show resolved Hide resolved
resolve comments
5041592 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 0981e72 to 5041592 Compare November 21, 2024 04:45
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch 2 times, most recently from feaf46d to 1c49d35 Compare November 25, 2024 02:32
add Index constructor
d6e8499 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 1c49d35 to d6e8499 Compare November 25, 2024 02:35
add license header
cf431f0 
Signed-off-by: Patrick Pan <[email protected]>
resolve merge conflicts
50e696e 
Signed-off-by: Patrick Pan <[email protected]>
add lock on SetReferrerState
856c0ef 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 2906727 to 856c0ef Compare November 29, 2024 05:22
Patrick Pan added 3 commits November 29, 2024 16:50
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 89afb0e to 7df36ca Compare December 3, 2024 02:31
@pat-pan
Copy link
Contributor Author

pat-pan commented Dec 12, 2024

hey @shizhMSFT , just check in with you to see if you have any comment on this PR.

shizhMSFT
shizhMSFT reviewed Dec 12, 2024
View reviewed changes
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Descriptor.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/Repository.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/Referrers.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/Referrers.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/Referrers.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/Referrers.cs Outdated Show resolved Hide resolved
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 2084061 to c105905 Compare December 13, 2024 04:35
resolve comments
c30d6b2 
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from c105905 to c30d6b2 Compare December 13, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT left review comments

@Wwwsylvia Wwwsylvia Wwwsylvia requested changes

@renshao renshao renshao left review comments

@sammychinedu2ky sammychinedu2ky Awaiting requested review from sammychinedu2ky sammychinedu2ky is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push Manifest with subject
4 participants
@pat-pan @renshao @Wwwsylvia @shizhMSFT