fix: remove subject existence check, add media type check #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #42
Resolves #50
Resolves #49
PR description:
References()
function. For subject we don't need to check existence, and we need to verify its media type. This is quite different from the validation of layers, blobs and configs (all included inReferences()
), and therefore it's better to move subject out ofReferences()
, as all elements ofReferences()
are checked in a loop and it's very hard to tell which one is the subject and differentiate its check.Signed-off-by: wangxiaoxuan273 [email protected]