Proper shut down for operator and webhook; Have webhook delete VWC

[rjeberhard]

The initial idea was that the webhook should delete the ValidatingWebhookConfiguration during its shutdown so that this resource would not be stranded.

While working on that, I discovered that neither the webhook or operator were really cleanly shutting down -- that is, the runtime signal handler was never being called. Therefore, I put in a preStop handler and added handling to make sure that either process would get to complete its shutdown behavior before exiting.

Then, I added the handling to the webhook to delete the VWC.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

83.9% Coverage
0.0% Duplication

[ankedia]

LGTM

[jshum2479]

LGTM, though there are common script lines in several places. If they can refactor in common places then it will avoid future errors when changing one file without others.

DEPLOYMENT_DIR="/deployment"
SHUTDOWN_MARKER_FILE="${DEPLOYMENT_DIR}/marker.shutdown"
SHUTDOWN_COMPLETE_MARKER_FILE="${DEPLOYMENT_DIR}/marker.shutdown-complete"

[rjeberhard]

LGTM, though there are common script lines in several places. If they can refactor in common places then it will avoid future errors when changing one file without others.

DEPLOYMENT_DIR="/deployment" SHUTDOWN_MARKER_FILE="${DEPLOYMENT_DIR}/marker.shutdown" SHUTDOWN_COMPLETE_MARKER_FILE="${DEPLOYMENT_DIR}/marker.shutdown-complete"

@jshum2479, is there a good pattern for this?

[rjeberhard]

@jshum2479, I think I will resolve the duplication of the DEPLOYMENT_DIR env variable later so that I can get this in.