add note for create-domain.sh #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosemarymarano
requested review from
bhavaniravichandran,
mriccell,
rjeberhard and
tbarnes-us
|
I'm leery of making the notice too verbose, but it could be a little more precise: The Could be: The |
tbarnes-us
approved these changes
May 18, 2021
tbarnes-us
left a comment
tbarnes-us
left a comment
There was a problem hiding this comment.
LGTM - Approving - I've suggested a small change but am not sure it should go in - leaving it up to you.
Contributor
Author
|
I am ok with the suggestion and have taken it. |
rjeberhard
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per OWLS-89511: Update doc for samples that use create-domain.sh