Merge pull request #2691 from oracle/owls_95240

OWLS-95240 - Reconcile running servers after the domain configuration change and fix for NPE

Author: robertpatrick

operator/src/main/java/oracle/kubernetes/operator/steps/ManagedServersUpStep.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2017, 2021, Oracle and/or its affiliates.
+// Copyright (c) 2017, 2022, Oracle and/or its affiliates.
 // Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
 
 package oracle.kubernetes.operator.steps;
@@ -15,6 +15,7 @@
 import java.util.stream.Collectors;
 import javax.annotation.Nonnull;
 
+import io.kubernetes.client.openapi.models.V1Pod;
 import oracle.kubernetes.operator.MakeRightDomainOperation;
 import oracle.kubernetes.operator.ProcessingConstants;
 import oracle.kubernetes.operator.helpers.DomainPresenceInfo;
@@ -35,6 +36,7 @@
 import oracle.kubernetes.weblogic.domain.model.ServerSpec;
 
 import static java.util.Comparator.comparing;
+import static oracle.kubernetes.operator.helpers.PodHelper.getPodServerName;
 
 public class ManagedServersUpStep extends Step {
   static final String SERVERS_UP_MSG =
@@ -103,7 +105,7 @@ public NextAction apply(Packet packet) {
       LOGGER.fine(SERVERS_UP_MSG, factory.domain.getDomainUid(), getRunningServers(info));
     }
 
-    Optional.ofNullable(config).ifPresent(wlsDomainConfig -> addServersToFactory(factory, wlsDomainConfig));
+    Optional.ofNullable(config).ifPresent(wlsDomainConfig -> addServersToFactory(factory, wlsDomainConfig, info));
 
     info.setServerStartupInfo(factory.getStartupInfos());
     info.setServerShutdownInfo(factory.getShutdownInfos());
@@ -116,7 +118,8 @@ public NextAction apply(Packet packet) {
         packet);
   }
 
-  private void addServersToFactory(@Nonnull ServersUpStepFactory factory, @Nonnull WlsDomainConfig wlsDomainConfig) {
+  private void addServersToFactory(@Nonnull ServersUpStepFactory factory, @Nonnull WlsDomainConfig wlsDomainConfig,
+                                   DomainPresenceInfo info) {
     Set<String> clusteredServers = new HashSet<>();
 
     List<ServerConfig> pendingServers = new ArrayList<>();
@@ -131,6 +134,15 @@ private void addServersToFactory(@Nonnull ServersUpStepFactory factory, @Nonnull
     for (ServerConfig serverConfig : pendingServers) {
       factory.addServerIfNeeded(serverConfig.wlsServerConfig, serverConfig.wlsClusterConfig);
     }
+
+    info.getServerPods().filter(pod -> !factory.getServers().contains(getPodServerName(pod)))
+            .filter(pod -> !getPodServerName(pod).equals(wlsDomainConfig.getAdminServerName()))
+            .forEach(pod -> shutdownServersNotPresentInDomainConfig(factory, pod));
+  }
+
+  private void shutdownServersNotPresentInDomainConfig(ServersUpStepFactory factory, V1Pod pod) {
+    WlsServerConfig serverConfig = new WlsServerConfig(getPodServerName(pod), PodHelper.getPodName(pod), 0);
+    factory.addShutdownInfo(new ServerShutdownInfo(serverConfig, pod.getMetadata().getClusterName(), null, false));
   }
 
   private void addClusteredServersToFactory(
@@ -242,6 +254,10 @@ Collection<DomainPresenceInfo.ServerShutdownInfo> getShutdownInfos() {
       return shutdownInfos;
     }
 
+    Collection<String> getServers() {
+      return servers;
+    }
+
     private void addStartupInfo(ServerStartupInfo startupInfo) {
       if (startupInfos == null) {
         startupInfos = new ArrayList<>();

operator/src/main/java/oracle/kubernetes/operator/steps/ReadHealthStep.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2018, 2021, Oracle and/or its affiliates.
+// Copyright (c) 2018, 2022, Oracle and/or its affiliates.
 // Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
 
 package oracle.kubernetes.operator.steps;
@@ -87,7 +87,6 @@ public NextAction apply(Packet packet) {
     String serverName = (String) packet.get(ProcessingConstants.SERVER_NAME);
     DomainPresenceInfo info = packet.getSpi(DomainPresenceInfo.class);
     V1Service service = info.getServerService(serverName);
-
     if (service == null) {
       return doNext(packet);
     } else {
@@ -191,6 +190,9 @@ static final class ReadHealthWithHttpStep extends Step {
     @Override
     public NextAction apply(Packet packet) {
       ReadHealthProcessing processing = new ReadHealthProcessing(packet, service, pod);
+      if (processing.getWlsServerConfig() == null) {
+        return doNext(packet);
+      }
       return doNext(createRequestStep(processing.createRequest(), new RecordHealthStep(getNext())), packet);
     }