Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subnet: update acc test #151

Merged
merged 1 commit into from
Jun 22, 2017
Merged

subnet: update acc test #151

merged 1 commit into from
Jun 22, 2017

Conversation

josephholsten
Copy link
Contributor

@josephholsten josephholsten commented Jun 16, 2017 •
edited
Loading

Identified while investigating #113

  • resource_obmcs_core_subnet: make dhcp_options_id, route_table_id, security_list_ids required
  • resource_obmcs_core_subnet_test: rewrite
  • provider_test: add required attributes to baremetal_core_subnet usage

@josephholsten josephholsten mentioned this pull request Jun 16, 2017
Closed
@josephholsten
Copy link
Contributor Author

oop, I've got an issue in data_source_obmcs_core_subnet_test.go, don't merge yet

@josephholsten
Copy link
Contributor Author

ok, I hope that's everything

@josephholsten josephholsten mentioned this pull request Jun 20, 2017
Closed
@mikejihbe
Copy link
Contributor

Isn't making these required a breaking change for existing configurations?

@josephholsten
Copy link
Contributor Author

@mikejihbe So far as I can tell, the default values don't actually work. So in practice, any configuration that isn't specifying them is broken. Any configuration which does specify them should be unchanged.

@mikejihbe
Copy link
Contributor

mikejihbe commented Jun 20, 2017 via email

@josephholsten
Copy link
Contributor Author

I probably should note this in the commit message. BTW, should we start maintaining a changelog?

@josephholsten
Copy link
Contributor Author

TODO: add example to doc

@josephholsten
subnet: fix default values for dhcp_options_id, route_table_id, secur…
227ede5 
…ity_list_ids

Default values in schema differ from the defaults provided by API, so any configuration not specifying them is broken. Any configuration which does specify them should be unchanged.

- resource_obmcs_core_subnet.go: make dhcp_options_id, route_table_id, security_list_ids required
- resource_obmcs_core_subnet_test.go: rewrite
- provider_test.go, data_source_obmcs_core_subnet_test.go: add required attributes
@josephholsten
Copy link
Contributor Author

doc updated

@codycushing
Copy link
Contributor

Legit. I wish there was a better solution for optional params not causing TF to act foolishly though :(

@codycushing codycushing merged commit 7598f30 into oracle:master Jun 22, 2017
@josephholsten
Copy link
Contributor Author

right? I tried a number of options before letting the other terraform contributors convince me that this was the least terrible option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephholsten @mikejihbe @codycushing