-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-41487] Add runtime pagesize validation. #5605
Conversation
Is that |
@@ -218,11 +219,19 @@ public static int run(int argc, CCharPointerPointer argv) { | |||
} | |||
} | |||
|
|||
private static final CGlobalData<CCharPointer> PAGE_SIZE_CHECK_FAIL_MESSAGE = CGlobalDataFactory | |||
.createCString("Image page size does not match the page size at run-time. Use -H:PageSize=[pagesize] to set appropriately."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...to set appropriately.
To set what appropriately? The image page size or the page size at run-time?
Right I can produce a native image with |
Yes, the page size at image creation (either the host page size or size set via We are currently exploring how practical it is to make the image further agnostic to the runtime page size. |
@teshull Thanks! Thanks! |
Yes, setting In terms of the tradeoffs of using 64K pages on a 4K machine, yes, there might be a little waste, but its impact should be minimal |
@teshull Thanks, that's what I wanted to hear! Happy holidays! |
409c4d5
to
9f953c1
Compare
9f953c1
to
18e28c4
Compare
No description provided.