Skip to content

Commit 3aee202

Browse files
committed
rename function
1 parent 547b000 commit 3aee202

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/oci_openai/oci_openai.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def __init__(
6565
default_query: Optional[Mapping[str, object]] = None,
6666
**kwargs: Any,
6767
) -> None:
68-
base_url = _override_base_url(region, service_endpoint, base_url)
68+
base_url = _resolve_base_url(region, service_endpoint, base_url)
6969

7070
if "generativeai" in base_url and not compartment_id:
7171
raise ValueError(
@@ -127,7 +127,7 @@ def __init__(
127127
default_query: Optional[Mapping[str, object]] = None,
128128
**kwargs: Any,
129129
) -> None:
130-
base_url = _override_base_url(region, service_endpoint, base_url)
130+
base_url = _resolve_base_url(region, service_endpoint, base_url)
131131

132132
if "generativeai" in base_url and not compartment_id:
133133
raise ValueError(
@@ -328,7 +328,7 @@ def _build_base_url(service_endpoint: str) -> str:
328328
return f"{url}/openai/v1"
329329

330330

331-
def _override_base_url(region: str = None, service_endpoint: str = None, base_url: str = None):
331+
def _resolve_base_url(region: str = None, service_endpoint: str = None, base_url: str = None):
332332
# build service endpoint by region when service_endpoint is empty,
333333
# then build base url from service endpoint
334334
if not base_url and not service_endpoint and not region:

tests/openai_tests/test_chat_api.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
_build_base_url,
1818
_build_headers,
1919
_build_service_endpoint,
20-
_override_base_url,
20+
_resolve_base_url,
2121
)
2222

2323
SERVICE_ENDPOINT = "https://generativeai.fake-oci-endpoint.com"
@@ -130,24 +130,24 @@ def test_build_base_url():
130130
assert result == f"{endpoint}/openai/v1"
131131

132132

133-
def test_override_base_url():
133+
def test_resolve_base_url():
134134
with pytest.raises(ValueError):
135-
_override_base_url()
135+
_resolve_base_url()
136136

137137
url = "https://datascience.us-phoenix-1.oci.oraclecloud.com/20190101/actions/invokeEndpoint"
138-
result = _override_base_url(region="any", service_endpoint="any", base_url=url)
138+
result = _resolve_base_url(region="any", service_endpoint="any", base_url=url)
139139
assert result == url
140140

141141
expected_url = "https://inference.generativeai.us-chicago-1.oci.oraclecloud.com/openai/v1"
142142
endpoint = "https://inference.generativeai.us-chicago-1.oci.oraclecloud.com"
143-
result = _override_base_url(region="any", service_endpoint=endpoint)
143+
result = _resolve_base_url(region="any", service_endpoint=endpoint)
144144
assert result == expected_url
145145

146146
endpoint = "https://inference.generativeai.us-chicago-1.oci.oraclecloud.com/ //"
147-
result = _override_base_url(region="any", service_endpoint=endpoint)
147+
result = _resolve_base_url(region="any", service_endpoint=endpoint)
148148
assert result == expected_url
149149

150-
result = _override_base_url("us-chicago-1")
150+
result = _resolve_base_url("us-chicago-1")
151151
assert result == expected_url
152152

153153

0 commit comments

Comments
 (0)