Skip to content

refact(forced-decision): Support for decision context added. #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msohailhussain merged 5 commits into from
Nov 2, 2021
Merged

refact(forced-decision): Support for decision context added. #288

msohailhussain merged 5 commits into from
Nov 2, 2021

Conversation

@ozayr-zaviar
Copy link
Contributor

@ozayr-zaviar ozayr-zaviar commented Oct 26, 2021

Summary

  • Updated forced-decision API request parameters.
  • Added OptimizelyDecisionContext and OptimizelyForcedDecision structs.

Testing

  • All existing unit test should pass.
  • All FSC cases should pass.

@ozayr-zaviar ozayr-zaviar removed their assignment Oct 26, 2021
@coveralls
Copy link

coveralls commented Oct 26, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 99.596% when pulling 54c03a0 on uzair/forced-decision-update into c778d08 on master.

yasirfolio3
yasirfolio3 reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain marked this pull request as ready for review October 28, 2021 05:03
@msohailhussain msohailhussain requested a review from a team as a code owner October 28, 2021 05:03
@msohailhussain msohailhussain requested a review from jaeopt November 1, 2021 21:34
jaeopt
jaeopt approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain merged commit 1977527 into master Nov 2, 2021
@msohailhussain msohailhussain deleted the uzair/forced-decision-update branch November 2, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@yasirfolio3 yasirfolio3 yasirfolio3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 24 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ozayr-zaviar @coveralls @yasirfolio3 @jaeopt @msohailhussain @optimizely-codereview-bot