WIP

Author: oakbani

src/Optimizely/DecisionService/DecisionService.php

@@ -177,7 +177,7 @@ public function getVariation(ProjectConfigInterface $projectConfig, Experiment $
             $decideReasons[] = $message;
         } else {
             if (!in_array(OptimizelyDecideOption::IGNORE_USER_PROFILE_SERVICE, $decideOptions)) {
-                $this->saveVariation($experiment, $variation, $userProfile, $decideReasons);
+                $this->saveVariation($experiment, $variation, $userProfile);
             }
             $message = sprintf(
                 'User "%s" is in variation %s of experiment %s.',
@@ -599,7 +599,7 @@ private function getStoredVariation(ProjectConfigInterface $projectConfig, Exper
      * @param $variation   Variation   Variation the user is bucketed into.
      * @param $userProfile UserProfile User profile object to which we are persisting the variation assignment.
      */
-    private function saveVariation(Experiment $experiment, Variation $variation, UserProfile $userProfile, &$decideReasons = [])
+    private function saveVariation(Experiment $experiment, Variation $variation, UserProfile $userProfile)
     {
         if (is_null($this->_userProfileService)) {
             return;
@@ -627,7 +627,6 @@ private function saveVariation(Experiment $experiment, Variation $variation, Use
             );
 
             $this->_logger->log(Logger::INFO, $message);
-            $decideReasons[] = $message;
         } catch (Exception $e) {
             $message = sprintf(
                 'Failed to save variation "%s" of experiment "%s" for user "%s".',
@@ -637,7 +636,6 @@ private function saveVariation(Experiment $experiment, Variation $variation, Use
             );
 
             $this->_logger->log(Logger::WARNING, $message);
-            $decideReasons[] = $message;
         }
     }
 }

src/Optimizely/DecisionService/FeatureDecision.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright 2017, 2019 Optimizely Inc and Contributors
+ * Copyright 2017, 2019-2020 Optimizely Inc and Contributors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/Optimizely/Enums/DecisionNotificationTypes.php

@@ -20,9 +20,9 @@
 class DecisionNotificationTypes
 {
     const AB_TEST = "ab-test";
+    const ALL_FEATURE_VARIABLES = "all-feature-variables";
     const FEATURE = "feature";
     const FEATURE_TEST = "feature-test";
     const FEATURE_VARIABLE = "feature-variable";
     const FLAG = "flag";
-    const ALL_FEATURE_VARIABLES = "all-feature-variables";
 }

src/Optimizely/Optimizely.php

@@ -253,7 +253,7 @@ protected function sendImpressionEvent($config, $experimentKey, $variationKey, $
 
     public function createUserContext($userId, array $userAttributes = [])
     {
-        // We do not check if config is ready as UserContext can be created evne when SDK is not ready.
+        // We do not check if config is ready as UserContext can be created even when SDK is not ready.
 
         // validate userId
         if (!$this->validateInputs(

tests/OptimizelyTest.php

@@ -16,8 +16,6 @@
  */
 namespace Optimizely\Tests;
 
-// require(dirname(__FILE__).'/TestData.php');
-
 use Exception;
 use GuzzleHttp\Client;
 use GuzzleHttp\Handler\MockHandler;

tests/OptimizelyUserContextTests.php

@@ -18,7 +18,6 @@
 
 require(dirname(__FILE__).'/TestData.php');
 
-
 use Exception;
 use TypeError;
 
@@ -29,8 +28,6 @@
 
 class OptimizelyUserContextTest extends \PHPUnit_Framework_TestCase
 {
-    const OUTPUT_STREAM = 'output';
-
     private $datafile;
     private $loggerMock;
     private $optimizelyObject;