requestID removed from JSON response, will be provided as header value

Author: r--w

api/controllers/ip.go

@@ -13,7 +13,6 @@ type IPResult struct {
 	Action        string `json:"action"`
 	Company       string `json:"company"`
 	Country       string `json:"country"`
-	RequestID     string `json:"id"`
 	BadReputation bool   `json:"bad"`
 	Bot           bool   `json:"bot"`
 	Datacenter    bool   `json:"dc"`
@@ -77,7 +76,6 @@ func (i *IP) Check(addr string) (*IPResult, error) {
 		Company:      info.Company,
 		Tor:          info.IsTor,
 		Proxy:        info.IsProxy,
-		RequestID:    info.RequestID,
 		SearchEngine: info.IsSearchEngine,
 		Private:      info.IsPrivate,
 		Spam:         info.IsSpam,

ip/ip.go

@@ -2,9 +2,7 @@ package ip
 
 import (
 	"context"
-	"math/rand" // #nosec
 	"net"
-	"strconv"
 	"time"
 
 	"github.com/optimatiq/threatbite/ip/datasource"
@@ -18,7 +16,6 @@ type Info struct {
 	Company        string
 	Country        string
 	Hostnames      []string
-	RequestID      string
 	IsProxy        bool
 	IsSearchEngine bool
 	IsTor          bool
@@ -162,12 +159,10 @@ func (i *IP) GetInfo(ip net.IP) (*Info, error) {
 		score = 100
 	}
 
-	// TODO(RW) the request_id is already generated at the middleware level it should be passed here
 	return &Info{
 		Company:        company,
 		Country:        country,
 		IsProxy:        isProxy,
-		RequestID:      "ID" + strconv.FormatInt(rand.Int63n(9223372036854775807), 10), // #nosec
 		IsSearchEngine: isSearch,
 		IsTor:          isTor,
 		Hostnames:      hostnames,