Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Complex numbers #1

Open
KSXGitHub opened this issue Mar 28, 2019 · 9 comments
Open

Suggestion: Complex numbers #1

KSXGitHub opened this issue Mar 28, 2019 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@KSXGitHub
Copy link

ln(-1) = πi

sqrt(-4) = 2i

@oppiliappan
Copy link
Owner

complex numbers would really complete the calculator idea, but i will be giving this a lower priority, simply because i dont quite see complex numbers being used in everyday calculations, and functions such as ln would have to be rewritten to support complex numbers.

(-1_f64.ln() returns 0)

@KSXGitHub
Copy link
Author

functions such as ln would have to be rewritten to support complex numbers.

You may not have to. Have you ever heard of nalgebra?

@oppiliappan oppiliappan added enhancement New feature or request help wanted Extra attention is needed labels Mar 29, 2019
@oppiliappan
Copy link
Owner

wew thats a lot more detailed than i imagined! i will look into it an try implementing complex numbers.

i hope it isint too hard to figure out :^)

@KSXGitHub
Copy link
Author

i will look into it an try implementing complex numbers.

i hope it isint too hard to figure out :^)

Why would you want to implement complex numbers yourself? The crate that I pointed you to already has it. You only need to use it.

@oppiliappan
Copy link
Owner

A lot of the lexing logic would have to be modified to accept complex inputs. currently alphabetical inputs only contribute to alphabets used in functions. this would have to be changed to detect iota etc.

once again, i have only taken a glance at the library and its capabilities, ill get to work when i get some time on my hands!

@KSXGitHub
Copy link
Author

A lot of the lexing logic would have to be modified to accept complex inputs

You don't have to accept complex inputs now. What I asked is to display complex output.

@Jackojc
Copy link

Jackojc commented Mar 31, 2019

You're being a bit pushy, this guy is developing the project in his own time out of his own free will and you're kind of coming across a bit aggressively.

@KSXGitHub
Copy link
Author

@Jackojc You think you know what others think?

@oppiliappan
Copy link
Owner

oppiliappan commented Mar 31, 2019

ahaha slow down a bit friendos!

this thread is for discussions related to the program. do not make personal jabs, or instigate other users / contributors.

that being said, i request @KSXGitHub to be more polite. Let all further discussion be constructive!

Repository owner locked and limited conversation to collaborators Mar 31, 2019
Repository owner unlocked this conversation Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants