fix mobile issues reported by claude

oposs · Oct 16, 2023 · 44f3e58 · 44f3e58
1 parent 05dec66
commit 44f3e58
Show file tree

Hide file tree

Showing 16 changed files with 102 additions and 60 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,39 @@
+0.12.0 2023-10-16 11:47:09 +0200 Tobias Oetiker <[email protected]>
+
+ -
+
+0.12.0 2023-10-16 11:45:03 +0200 Tobias Oetiker <[email protected]>
+
+ -
+
+0.12.0 2023-10-16 11:43:08 +0200 Tobias Oetiker <[email protected]>
+
+ -
+
+0.12.0 2023-10-16 11:41:26 +0200 Tobias Oetiker <[email protected]>
+
+ -
+
+0.12.0 2023-10-16 11:40:23 +0200 Tobias Oetiker <[email protected]>
+
+ -
+
+0.12.0 2023-10-16 11:33:28 +0200 Tobias Oetiker <[email protected]>
+
+ -
+
+0.12.0 2023-10-16 11:30:39 +0200 Tobias Oetiker <[email protected]>
+
+ -
+
+0.12.0 2023-10-16 11:27:14 +0200 Tobias Oetiker <[email protected]>
+
+ - location cleanup
+
+0.12.0 2023-10-16 11:19:26 +0200 Tobias Oetiker <[email protected]>
+
+ - add missing context edit
+
 0.12.0 2023-10-09 12:07:25 +0200 Tobias Oetiker <[email protected]>
 
  -

diff --git a/lib/OktDB/GuiPlugin/APFit.pm b/lib/OktDB/GuiPlugin/APFit.pm
@@ -93,7 +93,7 @@ has actionCfg => sub {
             label => trm('Edit APFit'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit APFit'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/APPrio.pm b/lib/OktDB/GuiPlugin/APPrio.pm
@@ -92,7 +92,7 @@ has actionCfg => sub {
             label => trm('Edit APPrio'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit APPrio'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/ArtPersMember.pm b/lib/OktDB/GuiPlugin/ArtPersMember.pm
@@ -120,7 +120,7 @@ has actionCfg => sub {
             label => trm('Edit ArtPersMember'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit ArtPersMember'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/Event.pm b/lib/OktDB/GuiPlugin/Event.pm
@@ -127,7 +127,7 @@ has actionCfg => sub {
             label => trm('Edit Event'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit Event'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/EventForm.pm b/lib/OktDB/GuiPlugin/EventForm.pm
@@ -83,7 +83,13 @@ has formCfg => sub {
                         [\"SUBSTR(location_name || COALESCE('; ' || location_postaladdress,''),0,60)" => 'title']
                     ],undef,{
                         order_by => 'location_name'
-                    })->hashes->to_array}
+                    })->hashes->map(sub {
+                        # clean up location names
+                        $_->{title} //= $_->{key} . ' - UNKNOWN';
+                        $_->{title} =~ s/\s+/ /g;
+                        $_->{title} =~ s/[^-_;.\s\w]/_/ig;
+                        return $_;
+                    })->to_array}
                 ]
             }
         },

diff --git a/lib/OktDB/GuiPlugin/Location.pm b/lib/OktDB/GuiPlugin/Location.pm
@@ -138,7 +138,7 @@ has actionCfg => sub {
             label => trm('Edit Location'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit Location'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/Okt.pm b/lib/OktDB/GuiPlugin/Okt.pm
@@ -98,7 +98,7 @@ has actionCfg => sub {
             label => trm('Edit Okt'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit Okt'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/OktEvent.pm b/lib/OktDB/GuiPlugin/OktEvent.pm
@@ -202,7 +202,7 @@ has actionCfg => sub {
             label => trm('View OktEvent'),
             action => 'popup',
             key => 'view',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('View OktEvent'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/Pers.pm b/lib/OktDB/GuiPlugin/Pers.pm
@@ -164,7 +164,7 @@ has actionCfg => sub {
             label => trm('Edit Person'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit Person'),
             buttonSet => {
                 enabled => false

diff --git a/lib/OktDB/GuiPlugin/Review.pm b/lib/OktDB/GuiPlugin/Review.pm
@@ -121,7 +121,7 @@ has actionCfg => sub {
             label => trm('Edit Review'),
             action => 'popup',
             key => 'edit',
-            addToContextMenu => false,
+            addToContextMenu => true,
             popupTitle => trm('Edit Review'),
             buttonSet => {
                 enabled => false

diff --git a/share/de.po b/share/de.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: oktdb 0.1.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2023-10-09 12:08+0200\n"
+"POT-Creation-Date: 2023-10-16 11:44+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[email protected]>\n"
@@ -93,7 +93,7 @@ msgstr ""
 #: /home/oetiker/checkouts/oktdb/thirdparty/lib/perl5/CallBackery/qooxdoo/../GuiPlugin/Users.pm:74
 #: lib/OktDB/GuiPlugin/Agency.pm:104 lib/OktDB/GuiPlugin/AgencyForm.pm:123
 #: lib/OktDB/GuiPlugin/ArtPers.pm:154 lib/OktDB/GuiPlugin/ArtPersForm.pm:305
-#: lib/OktDB/GuiPlugin/Event.pm:106 lib/OktDB/GuiPlugin/EventForm.pm:134
+#: lib/OktDB/GuiPlugin/Event.pm:106 lib/OktDB/GuiPlugin/EventForm.pm:140
 #: lib/OktDB/GuiPlugin/Location.pm:101 lib/OktDB/GuiPlugin/LocationForm.pm:110
 #: lib/OktDB/GuiPlugin/OktEvent.pm:113 lib/OktDB/GuiPlugin/OktEventForm.pm:211
 #: lib/OktDB/GuiPlugin/Pers.pm:120 lib/OktDB/GuiPlugin/PersForm.pm:135
@@ -118,7 +118,7 @@ msgstr ""
 #: lib/OktDB/GuiPlugin/APFitForm.pm:105 lib/OktDB/GuiPlugin/APPrioForm.pm:106
 #: lib/OktDB/GuiPlugin/AgencyForm.pm:177 lib/OktDB/GuiPlugin/ArtPersForm.pm:385
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:155
-#: lib/OktDB/GuiPlugin/EventForm.pm:172 lib/OktDB/GuiPlugin/LocationForm.pm:144
+#: lib/OktDB/GuiPlugin/EventForm.pm:178 lib/OktDB/GuiPlugin/LocationForm.pm:144
 #: lib/OktDB/GuiPlugin/OktEventForm.pm:253 lib/OktDB/GuiPlugin/OktForm.pm:134
 #: lib/OktDB/GuiPlugin/PersForm.pm:190
 #: lib/OktDB/GuiPlugin/ProductionForm.pm:151
@@ -373,7 +373,7 @@ msgstr ""
 #: lib/OktDB/GuiPlugin/ArtPersForm.pm:341
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:101
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:119
-#: lib/OktDB/GuiPlugin/EventForm.pm:103 lib/OktDB/GuiPlugin/OktEventForm.pm:184
+#: lib/OktDB/GuiPlugin/EventForm.pm:109 lib/OktDB/GuiPlugin/OktEventForm.pm:184
 #: lib/OktDB/GuiPlugin/OktEventForm.pm:203 lib/OktDB/GuiPlugin/OktForm.pm:80
 #: lib/OktDB/GuiPlugin/OktForm.pm:98 lib/OktDB/GuiPlugin/PersForm.pm:127
 #: lib/OktDB/GuiPlugin/PersForm.pm:153 lib/OktDB/GuiPlugin/ProductionForm.pm:89
@@ -570,7 +570,7 @@ msgstr ""
 msgid "Select Person"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/Event.pm:64 lib/OktDB/GuiPlugin/EventForm.pm:92
+#: lib/OktDB/GuiPlugin/Event.pm:64 lib/OktDB/GuiPlugin/EventForm.pm:98
 msgid "Date"
 msgstr ""
 
@@ -623,23 +623,23 @@ msgstr "Visionierung"
 msgid "Select Location"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:95 lib/OktDB/GuiPlugin/OktEventForm.pm:176
+#: lib/OktDB/GuiPlugin/EventForm.pm:101 lib/OktDB/GuiPlugin/OktEventForm.pm:176
 msgid "dd.mm.yyyy hh:mm"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:111
+#: lib/OktDB/GuiPlugin/EventForm.pm:117
 msgid "Leader"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:118
+#: lib/OktDB/GuiPlugin/EventForm.pm:124
 msgid "Select Leader"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:129
+#: lib/OktDB/GuiPlugin/EventForm.pm:135
 msgid "Tagalong People"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:173 lib/OktDB/GuiPlugin/Production.pm:158
+#: lib/OktDB/GuiPlugin/EventForm.pm:179 lib/OktDB/GuiPlugin/Production.pm:158
 msgid "Add Event"
 msgstr ""
 

diff --git a/share/en.po b/share/en.po
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: oktdb 0.1.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2023-10-09 12:08+0200\n"
+"POT-Creation-Date: 2023-10-16 11:44+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[email protected]>\n"
@@ -94,7 +94,7 @@ msgstr ""
 #: /home/oetiker/checkouts/oktdb/thirdparty/lib/perl5/CallBackery/qooxdoo/../GuiPlugin/Users.pm:74
 #: lib/OktDB/GuiPlugin/Agency.pm:104 lib/OktDB/GuiPlugin/AgencyForm.pm:123
 #: lib/OktDB/GuiPlugin/ArtPers.pm:154 lib/OktDB/GuiPlugin/ArtPersForm.pm:305
-#: lib/OktDB/GuiPlugin/Event.pm:106 lib/OktDB/GuiPlugin/EventForm.pm:134
+#: lib/OktDB/GuiPlugin/Event.pm:106 lib/OktDB/GuiPlugin/EventForm.pm:140
 #: lib/OktDB/GuiPlugin/Location.pm:101 lib/OktDB/GuiPlugin/LocationForm.pm:110
 #: lib/OktDB/GuiPlugin/OktEvent.pm:113 lib/OktDB/GuiPlugin/OktEventForm.pm:211
 #: lib/OktDB/GuiPlugin/Pers.pm:120 lib/OktDB/GuiPlugin/PersForm.pm:135
@@ -119,7 +119,7 @@ msgstr ""
 #: lib/OktDB/GuiPlugin/APFitForm.pm:105 lib/OktDB/GuiPlugin/APPrioForm.pm:106
 #: lib/OktDB/GuiPlugin/AgencyForm.pm:177 lib/OktDB/GuiPlugin/ArtPersForm.pm:385
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:155
-#: lib/OktDB/GuiPlugin/EventForm.pm:172 lib/OktDB/GuiPlugin/LocationForm.pm:144
+#: lib/OktDB/GuiPlugin/EventForm.pm:178 lib/OktDB/GuiPlugin/LocationForm.pm:144
 #: lib/OktDB/GuiPlugin/OktEventForm.pm:253 lib/OktDB/GuiPlugin/OktForm.pm:134
 #: lib/OktDB/GuiPlugin/PersForm.pm:190
 #: lib/OktDB/GuiPlugin/ProductionForm.pm:151
@@ -374,7 +374,7 @@ msgstr ""
 #: lib/OktDB/GuiPlugin/ArtPersForm.pm:341
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:101
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:119
-#: lib/OktDB/GuiPlugin/EventForm.pm:103 lib/OktDB/GuiPlugin/OktEventForm.pm:184
+#: lib/OktDB/GuiPlugin/EventForm.pm:109 lib/OktDB/GuiPlugin/OktEventForm.pm:184
 #: lib/OktDB/GuiPlugin/OktEventForm.pm:203 lib/OktDB/GuiPlugin/OktForm.pm:80
 #: lib/OktDB/GuiPlugin/OktForm.pm:98 lib/OktDB/GuiPlugin/PersForm.pm:127
 #: lib/OktDB/GuiPlugin/PersForm.pm:153 lib/OktDB/GuiPlugin/ProductionForm.pm:89
@@ -571,7 +571,7 @@ msgstr ""
 msgid "Select Person"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/Event.pm:64 lib/OktDB/GuiPlugin/EventForm.pm:92
+#: lib/OktDB/GuiPlugin/Event.pm:64 lib/OktDB/GuiPlugin/EventForm.pm:98
 msgid "Date"
 msgstr ""
 
@@ -624,23 +624,23 @@ msgstr ""
 msgid "Select Location"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:95 lib/OktDB/GuiPlugin/OktEventForm.pm:176
+#: lib/OktDB/GuiPlugin/EventForm.pm:101 lib/OktDB/GuiPlugin/OktEventForm.pm:176
 msgid "dd.mm.yyyy hh:mm"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:111
+#: lib/OktDB/GuiPlugin/EventForm.pm:117
 msgid "Leader"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:118
+#: lib/OktDB/GuiPlugin/EventForm.pm:124
 msgid "Select Leader"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:129
+#: lib/OktDB/GuiPlugin/EventForm.pm:135
 msgid "Tagalong People"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:173 lib/OktDB/GuiPlugin/Production.pm:158
+#: lib/OktDB/GuiPlugin/EventForm.pm:179 lib/OktDB/GuiPlugin/Production.pm:158
 msgid "Add Event"
 msgstr ""
 

diff --git a/share/fr.po b/share/fr.po
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: oktdb 0.1.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2023-10-09 12:08+0200\n"
+"POT-Creation-Date: 2023-10-16 11:44+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[email protected]>\n"
@@ -94,7 +94,7 @@ msgstr ""
 #: /home/oetiker/checkouts/oktdb/thirdparty/lib/perl5/CallBackery/qooxdoo/../GuiPlugin/Users.pm:74
 #: lib/OktDB/GuiPlugin/Agency.pm:104 lib/OktDB/GuiPlugin/AgencyForm.pm:123
 #: lib/OktDB/GuiPlugin/ArtPers.pm:154 lib/OktDB/GuiPlugin/ArtPersForm.pm:305
-#: lib/OktDB/GuiPlugin/Event.pm:106 lib/OktDB/GuiPlugin/EventForm.pm:134
+#: lib/OktDB/GuiPlugin/Event.pm:106 lib/OktDB/GuiPlugin/EventForm.pm:140
 #: lib/OktDB/GuiPlugin/Location.pm:101 lib/OktDB/GuiPlugin/LocationForm.pm:110
 #: lib/OktDB/GuiPlugin/OktEvent.pm:113 lib/OktDB/GuiPlugin/OktEventForm.pm:211
 #: lib/OktDB/GuiPlugin/Pers.pm:120 lib/OktDB/GuiPlugin/PersForm.pm:135
@@ -119,7 +119,7 @@ msgstr ""
 #: lib/OktDB/GuiPlugin/APFitForm.pm:105 lib/OktDB/GuiPlugin/APPrioForm.pm:106
 #: lib/OktDB/GuiPlugin/AgencyForm.pm:177 lib/OktDB/GuiPlugin/ArtPersForm.pm:385
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:155
-#: lib/OktDB/GuiPlugin/EventForm.pm:172 lib/OktDB/GuiPlugin/LocationForm.pm:144
+#: lib/OktDB/GuiPlugin/EventForm.pm:178 lib/OktDB/GuiPlugin/LocationForm.pm:144
 #: lib/OktDB/GuiPlugin/OktEventForm.pm:253 lib/OktDB/GuiPlugin/OktForm.pm:134
 #: lib/OktDB/GuiPlugin/PersForm.pm:190
 #: lib/OktDB/GuiPlugin/ProductionForm.pm:151
@@ -374,7 +374,7 @@ msgstr ""
 #: lib/OktDB/GuiPlugin/ArtPersForm.pm:341
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:101
 #: lib/OktDB/GuiPlugin/ArtPersMemberForm.pm:119
-#: lib/OktDB/GuiPlugin/EventForm.pm:103 lib/OktDB/GuiPlugin/OktEventForm.pm:184
+#: lib/OktDB/GuiPlugin/EventForm.pm:109 lib/OktDB/GuiPlugin/OktEventForm.pm:184
 #: lib/OktDB/GuiPlugin/OktEventForm.pm:203 lib/OktDB/GuiPlugin/OktForm.pm:80
 #: lib/OktDB/GuiPlugin/OktForm.pm:98 lib/OktDB/GuiPlugin/PersForm.pm:127
 #: lib/OktDB/GuiPlugin/PersForm.pm:153 lib/OktDB/GuiPlugin/ProductionForm.pm:89
@@ -571,7 +571,7 @@ msgstr ""
 msgid "Select Person"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/Event.pm:64 lib/OktDB/GuiPlugin/EventForm.pm:92
+#: lib/OktDB/GuiPlugin/Event.pm:64 lib/OktDB/GuiPlugin/EventForm.pm:98
 msgid "Date"
 msgstr ""
 
@@ -624,23 +624,23 @@ msgstr ""
 msgid "Select Location"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:95 lib/OktDB/GuiPlugin/OktEventForm.pm:176
+#: lib/OktDB/GuiPlugin/EventForm.pm:101 lib/OktDB/GuiPlugin/OktEventForm.pm:176
 msgid "dd.mm.yyyy hh:mm"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:111
+#: lib/OktDB/GuiPlugin/EventForm.pm:117
 msgid "Leader"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:118
+#: lib/OktDB/GuiPlugin/EventForm.pm:124
 msgid "Select Leader"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:129
+#: lib/OktDB/GuiPlugin/EventForm.pm:135
 msgid "Tagalong People"
 msgstr ""
 
-#: lib/OktDB/GuiPlugin/EventForm.pm:173 lib/OktDB/GuiPlugin/Production.pm:158
+#: lib/OktDB/GuiPlugin/EventForm.pm:179 lib/OktDB/GuiPlugin/Production.pm:158
 msgid "Add Event"
 msgstr ""