diff --git a/.changeset/busy-bikes-walk.md b/.changeset/busy-bikes-walk.md new file mode 100644 index 0000000000..da882bffbd --- /dev/null +++ b/.changeset/busy-bikes-walk.md @@ -0,0 +1,5 @@ +--- +'@openproject/primer-view-components': patch +--- + +Use translatable string for aria label of clearing button in TextField diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark.png index 77cf09b596..d34ab1b82f 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_colorblind.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_colorblind.png index bec83a07fd..a9f1f2f611 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_colorblind.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_colorblind.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_dimmed.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_dimmed.png index ae0de7b666..cb3721962e 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_dimmed.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_dimmed.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_high_contrast.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_high_contrast.png index 1c9fa52a50..501e481c3b 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_high_contrast.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/dark_high_contrast.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/light_colorblind.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/light_colorblind.png index 323cd3d2d9..8b7c4900e5 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/light_colorblind.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/light_colorblind.png differ diff --git a/app/lib/primer/forms/text_field.html.erb b/app/lib/primer/forms/text_field.html.erb index 562f01098b..50f80ee5e7 100644 --- a/app/lib/primer/forms/text_field.html.erb +++ b/app/lib/primer/forms/text_field.html.erb @@ -13,7 +13,7 @@ <%= builder.text_field(@input.name, **@input.input_arguments) %> <% end %> <% if @input.show_clear_button? %> - <% end %> diff --git a/config/locales/en.yml b/config/locales/en.yml index 5ab9a1fa97..12f9dde392 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -1,6 +1,7 @@ en: button_back: "Back" button_cancel: "Cancel" + button_clear: "Clear" button_close: "Close" button_delete: "Delete" button_delete_permanently: "Delete permanently"