Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove re-execution of edited commands from Cog. #1013

Closed
imbriaco opened this issue Oct 5, 2016 · 0 comments
Closed

Remove re-execution of edited commands from Cog. #1013

imbriaco opened this issue Oct 5, 2016 · 0 comments
Assignees
Milestone

Comments

@imbriaco
Copy link
Member

imbriaco commented Oct 5, 2016

Currently (at least in Slack) if you edit a previous message that contained a command, Cog will attempt to re-execute the edited command. This has some unintended consequences:

  1. It may not be obvious when an edit takes place for an invocation that has scrolled off the screen what the context was for the intended execution.
  2. When Slack "unfurls" content, that manifests to the API as an edited message. In this case, you can see Cog execute a command, Slack edit the message to unfurl content, then Cog execute it again. This can happen so quickly that it appears as if Cog executed the command twice.

Let's remove this behavior, particularly now that Slack has a preference to make up/down arrow cycle through history in the entry field rather than via message editing. This was a good idea at the time but it's much more preferable for it to be as obvious as possible about the source of any command that Cog executes.

@imbriaco imbriaco added this to the Cog 0.15 milestone Oct 5, 2016
@kevsmith kevsmith self-assigned this Oct 5, 2016
@kevsmith kevsmith added the review label Oct 5, 2016
@kevsmith kevsmith removed the review label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants