Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the return value of s3 object deletes #491

Open
audiodude opened this issue Aug 27, 2022 · 0 comments
Open

Check the return value of s3 object deletes #491

audiodude opened this issue Aug 27, 2022 · 0 comments

Comments

@audiodude
Copy link
Member

Currently, s3 object deletes in wp1/logic/selection.py doesn't check the return value of the s3 RPC and always returns true. It would be nice to check the return value, though it seems excessively complicated to do so. Either way, it's not particularly important because it's not clear what we would do if any of them failed besides log it (we don't want to fail the whole deletion process since s3 objects can be cleaned up later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant