[XLA] fail if the change bit reported by a pass does not agree with HLO hash comparison #22302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_723053879
branch
15 times, most recently
from
21c6019 to
32a1cf4
Compare
copybara-service
bot
force-pushed
the
test_723053879
branch
4 times, most recently
from
0947899 to
15332d7
Compare
…LO hash comparison Usually we trust that pass truthfully reports if it did update the HLO. Shockingly there are cases, e.g. algsimp, that wrongly report "unchanged" pass result. Having a flag makes it easier to detect existing and new cases of such bugs. PiperOrigin-RevId: 738733528
copybara-service
bot
force-pushed
the
test_723053879
branch
from
15332d7 to
2b11f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA] fail if the change bit reported by a pass does not agree with HLO hash comparison
Usually we trust that pass truthfully reports if it did update the HLO.
Shockingly there are cases, e.g. algsimp, that wrongly report "unchanged" pass result.
Having a flag makes it easier to detect existing and new cases of such bugs.