Skip to content

Commit 1f17e41

Browse files
nxhackhnyman
authored andcommitted
node: Preparing to update ICU to 76
fix building with system icu 76 ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer add `icu-uc` when linking to shared libraries. This results in undefined symbols/references when trying to build with system ICU 76. [^1]: unicode-org/icu@199bc82 ref: nodejs/node#55563 Signed-off-by: Hirokazu MORIKAWA <[email protected]>
1 parent dd3c410 commit 1f17e41

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

lang/node/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
99

1010
PKG_NAME:=node
1111
PKG_VERSION:=20.18.0
12-
PKG_RELEASE:=1
12+
PKG_RELEASE:=2
1313

1414
PKG_SOURCE:=$(PKG_NAME)-v$(PKG_VERSION).tar.gz
1515
PKG_SOURCE_URL:=https://nodejs.org/dist/v$(PKG_VERSION)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
From 54299ac3a3d4e4520b8604dce43c2584092ccde2 Mon Sep 17 00:00:00 2001
2+
From: Michael Cho <[email protected]>
3+
Date: Sun, 27 Oct 2024 10:08:07 -0400
4+
Subject: [PATCH] build: fix building with system icu 76
5+
6+
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer
7+
add `icu-uc` when linking to shared libraries. This results in undefined
8+
symbols/references when trying to build with system ICU 76.
9+
10+
[^1]: unicode-org/icu@199bc82
11+
---
12+
configure.py | 2 +-
13+
1 file changed, 1 insertion(+), 1 deletion(-)
14+
15+
--- a/configure.py
16+
+++ b/configure.py
17+
@@ -1829,7 +1829,7 @@ def configure_intl(o):
18+
elif with_intl == 'system-icu':
19+
# ICU from pkg-config.
20+
o['variables']['v8_enable_i18n_support'] = 1
21+
- pkgicu = pkg_config('icu-i18n')
22+
+ pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
23+
if not pkgicu[0]:
24+
error('''Could not load pkg-config data for "icu-i18n".
25+
See above errors or the README.md.''')

0 commit comments

Comments
 (0)