Skip to content

luci-app-upnp: Revision, new network access control and UCI options… #7822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Self-Hosting-Group wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

luci-app-upnp: Revision, new network access control and UCI options… #7822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
146f4da
luci-app-upnp: improve existing UI slightly
Self-Hosting-Group Jan 2, 2026
9d98f9d
luci-app-upnp: add `UPnP IGD Adjustments` tab
Self-Hosting-Group Jan 2, 2026
eba65fb
luci-app-upnp: revision and adapt to updated package options
Self-Hosting-Group Jan 2, 2026
0d99e08
luci-app-upnp: rename UCI section name to `settings` (v2.0)
Self-Hosting-Group Jan 2, 2026
2faa58b
luci-app-upnp: add second CGNAT UCI option
Self-Hosting-Group Jan 2, 2026
f11066b
luci-app-upnp: update ACL options, migrate section
Self-Hosting-Group Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/luci-app-upnp/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

include $(TOPDIR)/rules.mk

LUCI_TITLE:=UPnP IGD & PCP/NAT-PMP configuration module | Universal Plug and Play
LUCI_TITLE:=LuCI support for UPnP IGD & PCP/NAT-PMP service | originally: Universal Plug and Play
LUCI_DEPENDS:=+luci-base +miniupnpd +rpcd-mod-ucode

PKG_LICENSE:=Apache-2.0
Expand Down
29 changes: 15 additions & 14 deletions applications/luci-app-upnp/htdocs/luci-static/resources/view/status/include/80_upnp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
const callUpnpGetStatus = rpc.declare({
object: 'luci.upnp',
method: 'get_status',
expect: { }
expect: {}
});

const callUpnpDeleteRule = rpc.declare({
object: 'luci.upnp',
method: 'delete_rule',
params: [ 'token' ],
expect: { result : "OK" },
params: ['token'],
expect: { result: 'OK' },
});

function handleDelRule(num, ev) {
Expand All @@ -35,23 +35,23 @@ return baseclass.extend({
},

render: function(data) {
var table = E('table', { 'class': 'table', 'id': 'upnp_status_table' }, [
const table = E('table', { 'class': 'table', 'id': 'upnp_status_table' }, [
E('tr', { 'class': 'tr table-titles' }, [
E('th', { 'class': 'th' }, _('Client Name')),
E('th', { 'class': 'th' }, _('Client Address')),
E('th', { 'class': 'th' }, _('Client Port')),
E('th', { 'class': 'th' }, _('External Port')),
E('th', { 'class': 'th' }, _('Hostname')),
E('th', { 'class': 'th' }, _('IP address')),
E('th', { 'class': 'th' }, _('Port')),
E('th', { 'class': 'th' }, _('External port')),
E('th', { 'class': 'th' }, _('Protocol')),
E('th', { 'class': 'th right' }, _('Expires')),
E('th', { 'class': 'th' }, _('Description')),
E('th', { 'class': 'th' }, _('Added via / description')),
E('th', { 'class': 'th cbi-section-actions' }, '')
])
]);

var rules = Array.isArray(data[0].rules) ? data[0].rules : [];
const rules = Array.isArray(data[0].rules) ? data[0].rules : [];

var rows = rules.map(function(rule) {
const padnum = (num, length) => num.toString().padStart(length, "0");
const rows = rules.map(function(rule) {
const padnum = (num, length) => num.toString().padStart(length, '0');
const expires_sec = rule?.expires || 0;
const hour = Math.floor(expires_sec / 3600);
const minute = Math.floor((expires_sec % 3600) / 60);
Expand All @@ -72,8 +72,9 @@ return baseclass.extend({
rule.descr,
E('button', {
'class': 'btn cbi-button-remove',
'click': L.bind(handleDelRule, this, rule.num)
}, [ _('Delete') ])
'click': L.bind(handleDelRule, this, rule.num),
'title': _('Delete')
}, [_('Delete')])
];
});

Expand Down
Loading
Loading