Skip to content

Commit

Permalink
AES-NI asm: Specify previously missed XMM register clobbers
Browse files Browse the repository at this point in the history
Noticed by Gilles Peskine of upstream Mbed TLS
  • Loading branch information
solardiz committed Dec 8, 2024
1 parent af043dd commit e2a1b64
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/mbedtls/aesni.c
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ static void aesni_setkey_enc_128(unsigned char *rk,
AESKEYGENA(xmm0_xmm1, "0x36") "call 1b \n\t"
:
: "r" (rk), "r" (key)
: "memory", "cc", "0");
: "memory", "cc", "xmm0", "xmm1", "0");
}

/*
Expand Down Expand Up @@ -738,7 +738,7 @@ static void aesni_setkey_enc_192(unsigned char *rk,

:
: "r" (rk), "r" (key)
: "memory", "cc", "0");
: "memory", "cc", "xmm0", "xmm1", "xmm2", "0");
}
#endif /* !MBEDTLS_AES_ONLY_128_BIT_KEY_LENGTH */

Expand Down Expand Up @@ -806,7 +806,7 @@ static void aesni_setkey_enc_256(unsigned char *rk,
AESKEYGENA(xmm1_xmm2, "0x40") "call 1b \n\t"
:
: "r" (rk), "r" (key)
: "memory", "cc", "0");
: "memory", "cc", "xmm0", "xmm1", "xmm2", "0");
}
#endif /* !MBEDTLS_AES_ONLY_128_BIT_KEY_LENGTH */

Expand Down

0 comments on commit e2a1b64

Please sign in to comment.