Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circuit flamegraphs to openvm-prof #1156

Open
jonathanpwang opened this issue Jan 2, 2025 · 2 comments
Open

Add circuit flamegraphs to openvm-prof #1156

jonathanpwang opened this issue Jan 2, 2025 · 2 comments

Comments

@jonathanpwang
Copy link
Contributor

Move ci/scripts/metrics_unify/flamegraph.py to openvm-prof (in a flamegraph.rs file)
I think we could directly use inferno without a subprocess call to cargo-flamegraph.

@alv-around
Copy link
Contributor

What about samply, (flamegrpah.rs recomend it in their README.md). I tested on the sdk you just need define a [profile.profiling] and works out-of-box.

@jonathanpwang
Copy link
Contributor Author

What about samply, (flamegrpah.rs recomend it in their README.md). I tested on the sdk you just need define a [profile.profiling] and works out-of-box.

Here I am referring to this script which is for circuit flamegraphs where we emit custom metrics (similar to linux perf but specific to VM / STARKs). The python script parses them into a format compatible with flamegraph. Indeed you could also output a profile.json that could be given to samply -- I haven't looked into this but it would be cool.

@jonathanpwang jonathanpwang changed the title Add flamegraphs to openvm-prof Add circuit flamegraphs to openvm-prof Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants