From 7247a098ece67e8355c581efa20127f03946d66a Mon Sep 17 00:00:00 2001 From: Pawel Date: Tue, 7 Oct 2025 12:42:35 +0200 Subject: [PATCH 1/3] logging config before processing mediapipe config, added condition to open file only when debug level or below --- src/modelmanager.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modelmanager.cpp b/src/modelmanager.cpp index 029b82dd63..fad7f10d45 100644 --- a/src/modelmanager.cpp +++ b/src/modelmanager.cpp @@ -681,11 +681,13 @@ Status ModelManager::loadMediapipeGraphsConfig(std::vector Status firstErrorStatus = StatusCode::OK; try { for (const auto& mediapipeGraphConfig : mediapipesInConfigFile) { + if(mediapipeGraphConfig && spdlog::default_logger_raw()->level() <= spdlog::level::debug){ + mediapipeGraphConfig.logGraphConfigContent(); + } + auto status = processMediapipeConfig(mediapipeGraphConfig, mediapipesInConfigFileNames, mediapipeFactory); if (status != StatusCode::OK) { IF_ERROR_NOT_OCCURRED_EARLIER_THEN_SET_FIRST_ERROR(status); - } else { - mediapipeGraphConfig.logGraphConfigContent(); } } mediapipeFactory.retireOtherThan(std::move(mediapipesInConfigFileNames), *this); From 6d6d366b591cb8144f0a31ec926583048f42f388 Mon Sep 17 00:00:00 2001 From: Pawel Date: Tue, 7 Oct 2025 13:19:26 +0200 Subject: [PATCH 2/3] adding nullcheck --- src/modelmanager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modelmanager.cpp b/src/modelmanager.cpp index fad7f10d45..0dfe3cad19 100644 --- a/src/modelmanager.cpp +++ b/src/modelmanager.cpp @@ -681,7 +681,7 @@ Status ModelManager::loadMediapipeGraphsConfig(std::vector Status firstErrorStatus = StatusCode::OK; try { for (const auto& mediapipeGraphConfig : mediapipesInConfigFile) { - if(mediapipeGraphConfig && spdlog::default_logger_raw()->level() <= spdlog::level::debug){ + if(mediapipeGraphConfig != nullptr && spdlog::default_logger_raw()->level() <= spdlog::level::debug){ mediapipeGraphConfig.logGraphConfigContent(); } From cf59f676263b6971c2463292480e812ecb92c420 Mon Sep 17 00:00:00 2001 From: Pawel Date: Tue, 7 Oct 2025 13:23:57 +0200 Subject: [PATCH 3/3] removing condition for null config --- src/modelmanager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modelmanager.cpp b/src/modelmanager.cpp index 0dfe3cad19..f6ceaacf2c 100644 --- a/src/modelmanager.cpp +++ b/src/modelmanager.cpp @@ -681,7 +681,7 @@ Status ModelManager::loadMediapipeGraphsConfig(std::vector Status firstErrorStatus = StatusCode::OK; try { for (const auto& mediapipeGraphConfig : mediapipesInConfigFile) { - if(mediapipeGraphConfig != nullptr && spdlog::default_logger_raw()->level() <= spdlog::level::debug){ + if (spdlog::default_logger_raw()->level() <= spdlog::level::debug) { mediapipeGraphConfig.logGraphConfigContent(); }