From a5ef834cd202293cfe112e05c4b0a1776b610063 Mon Sep 17 00:00:00 2001
From: yosefe <yosefe@mellanox.com>
Date: Sun, 30 Nov 2014 15:27:46 +0200
Subject: [PATCH 1/3] UCS/CLASS: Fix destructor counting

---
 src/ucs/type/class.h | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/ucs/type/class.h b/src/ucs/type/class.h
index 991c51edc0a..d240a4d4780 100644
--- a/src/ucs/type/class.h
+++ b/src/ucs/type/class.h
@@ -53,8 +53,8 @@ struct ucs_class {
  * Class initialization/cleanup function prototypes.
  */
 #define UCS_CLASS_INIT_FUNC(_type, ...) \
-    ucs_status_t _UCS_CLASS_INIT_NAME(_type)(_type *self, ## __VA_ARGS__, \
-                                      ucs_class_t *_myclass, int *_init_count)
+    ucs_status_t _UCS_CLASS_INIT_NAME(_type)(_type *self, ucs_class_t *_myclass, \
+                                             int *_init_count, ## __VA_ARGS__)
 #define UCS_CLASS_CLEANUP_FUNC(_type) \
     void _UCS_CLASS_CLEANUP_NAME(_type)(_type *self)
 
@@ -89,10 +89,11 @@ struct ucs_class {
     ({ \
         UCS_CLASS_DECLARE(_type) \
         ucs_class_t *cls = &_UCS_CLASS_DECL_NAME(_type); \
-        int init_count = 0; \
+        int init_count = 1; \
         ucs_status_t status; \
         \
-        status = _UCS_CLASS_INIT_NAME(_type)((_type*)(_obj), ## __VA_ARGS__, cls, &init_count); \
+        status = _UCS_CLASS_INIT_NAME(_type)((_type*)(_obj), cls, &init_count, \
+                                             ## __VA_ARGS__); \
         if (status != UCS_OK) { \
             _ucs_class_call_cleanup_chain(&_UCS_CLASS_DECL_NAME(_type), \
                                           (_obj), init_count); \
@@ -171,12 +172,14 @@ struct ucs_class {
 #define UCS_CLASS_CALL_SUPER_INIT(...) \
     { \
         ucs_status_t status = \
-            _myclass->superclass->init(self, ## __VA_ARGS__, \
-                                       _myclass->superclass, _init_count); \
+            _myclass->superclass->init(self, _myclass->superclass, _init_count, \
+                                       ## __VA_ARGS__); \
         if (status != UCS_OK) { \
             return status; \
         } \
-        ++(*_init_count); \
+        if (_myclass->superclass != &_UCS_CLASS_DECL_NAME(void)) { \
+            ++(*_init_count); \
+        } \
     }
 
 
@@ -257,4 +260,9 @@ struct ucs_class {
 void _ucs_class_call_cleanup_chain(ucs_class_t *cls, void *obj, int limit);
 
 
+/**
+ * The empty class.
+ */
+UCS_CLASS_DECLARE(void);
+
 #endif

From bfac209665812008b4e7d8c3bf3202041d08000b Mon Sep 17 00:00:00 2001
From: yosefe <yosefe@mellanox.com>
Date: Wed, 3 Dec 2014 18:09:40 +0200
Subject: [PATCH 2/3] UCS/CLASS: Add macros to declare new/delete prototypes

---
 src/ucs/type/class.h | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/ucs/type/class.h b/src/ucs/type/class.h
index d240a4d4780..69a96c7113f 100644
--- a/src/ucs/type/class.h
+++ b/src/ucs/type/class.h
@@ -197,12 +197,13 @@ struct ucs_class {
  *      status = _type##_new(arg1, arg2, arg3, &obj);
  * }
  */
-#define UCS_CLASS_DEFINE_NEW_FUNC(_type, _argtype, ...) \
+#define UCS_CLASS_DECLARE_NEW_FUNC(_type, _argtype, ...) \
     ucs_status_t UCS_CLASS_NEW_FUNC_NAME(_type)( \
                     UCS_PP_FOREACH(_UCS_CLASS_INIT_ARG_DEFINE, _, \
                                    UCS_PP_ZIP((UCS_PP_SEQ(UCS_PP_NUM_ARGS(__VA_ARGS__))), (__VA_ARGS__))) \
-                                   _argtype **obj_p) \
-    { \
+                                   _argtype **obj_p)
+#define UCS_CLASS_DEFINE_NEW_FUNC(_type, _argtype, ...) \
+    UCS_CLASS_DECLARE_NEW_FUNC(_type, _argtype, ## __VA_ARGS__) { \
         return UCS_CLASS_NEW(_type, obj_p \
                              UCS_PP_FOREACH(_UCS_CLASS_INIT_ARG_PASS, _, \
                                             UCS_PP_SEQ(UCS_PP_NUM_ARGS(__VA_ARGS__)))); \
@@ -236,8 +237,10 @@ struct ucs_class {
  *      _type *obj = ...;
  *      _type##_delete(obj);
  */
+#define UCS_CLASS_DECLARE_DELETE_FUNC(_type, _argtype) \
+    void UCS_CLASS_DELETE_FUNC_NAME(_type)(_argtype *self)
 #define UCS_CLASS_DEFINE_DELETE_FUNC(_type, _argtype) \
-    void UCS_CLASS_DELETE_FUNC_NAME(_type)(_argtype *self) \
+    UCS_CLASS_DECLARE_DELETE_FUNC(_type, _argtype) \
     { \
         UCS_CLASS_DELETE(_type, self); \
     }

From 35ba320484da9c0a3ba1eefcdd8991996bd13f04 Mon Sep 17 00:00:00 2001
From: yosefe <yosefe@mellanox.com>
Date: Mon, 8 Dec 2014 16:23:02 +0200
Subject: [PATCH 3/3] UCS/CLASS: Add assertions on _init_count.

---
 src/ucs/type/class.c | 2 ++
 src/ucs/type/class.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/src/ucs/type/class.c b/src/ucs/type/class.c
index ce00bb832df..949acb5dfba 100644
--- a/src/ucs/type/class.c
+++ b/src/ucs/type/class.c
@@ -32,6 +32,8 @@ void _ucs_class_call_cleanup_chain(ucs_class_t *cls, void *obj, int limit)
     ucs_class_t *c;
     int depth, skip;
 
+    ucs_assert((limit == -1) || (limit >= 1));
+
     /* Count how many classes are there */
     for (depth = 0, c = cls; c != NULL; ++depth, c = c->superclass);
 
diff --git a/src/ucs/type/class.h b/src/ucs/type/class.h
index 69a96c7113f..073823d5083 100644
--- a/src/ucs/type/class.h
+++ b/src/ucs/type/class.h
@@ -171,6 +171,7 @@ struct ucs_class {
  */
 #define UCS_CLASS_CALL_SUPER_INIT(...) \
     { \
+        ucs_assert(*_init_count >= 1); \
         ucs_status_t status = \
             _myclass->superclass->init(self, _myclass->superclass, _init_count, \
                                        ## __VA_ARGS__); \