Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of SDK has doubled #474

Closed
danmajercak opened this issue Aug 9, 2023 · 20 comments
Closed

Size of SDK has doubled #474

danmajercak opened this issue Aug 9, 2023 · 20 comments

Comments

@danmajercak
Copy link

Describe the bug
Since opentok-android-sdk 2.25.2, the size of sdk has doubled compared to previous version
Was that on purpose? What has changed tha size has grown so much?

Screenshots

Screenshot 2023-08-09 at 10 06 04
Screenshot 2023-08-09 at 10 06 14

@v-kpheng
Copy link
Contributor

v-kpheng commented Aug 9, 2023

@danmajercak, the size of the SDK grew due to support for the Media Processor APIs, which was introduced as a beta feature in Android SDK 2.25.3.

@danmajercak
Copy link
Author

Does it have to be part of the original sdk? We currently do not want to use this beta feature. But increasing the size of sdk is a blocker for us. Couldn't it be created as a separate dependency and clients who would be interested in this feature would add it?

@emartynov
Copy link

I saw that 2.25.2 also grew without the beta functionality announcement.

@goncalocostamendes
Copy link
Contributor

goncalocostamendes commented Aug 16, 2023

@danmajercak @emartynov as @v-kpheng mentioned, the SDK grew only due to Media Processor APIs, which provides Background Blur and video/audio custom transformers to publisher's media stream. Even though it was only introduced as a beta feature in Android SDK 2.25.3, it was already part of 2.25.2.

We are working in a solution to provide Media Processor APIs as an additional dependency, but there is no ETA for it at the moment.

Meanwhile, if the size increase is a blocker, I ask to remain with v2.25.1 until further notice

@wlTrunks
Copy link

is there any way to exclude this Media Processor API, size of sdk too big

@goncalocostamendes
Copy link
Contributor

@wlTrunks at the moment, there isn't. I would ask you to remain with v2.25.1. We are working on providing Media Processor functionalities as a plugin that you can add to the SDK, but we have not finalise it yet

@v-kpheng
Copy link
Contributor

v-kpheng commented Oct 3, 2023

Just wanted to share an update. We'll work with product on this. Hope we can deliver this in Q1.
I'll share a link to the internal ticket once it's created.

@v-kpheng
Copy link
Contributor

v-kpheng commented Oct 3, 2023

We're tracking this internally: https://jira.vonage.com/browse/VPF-499.

@ntustzeus
Copy link

any solution or workaround to reduce the sdk size?
I build a project that import com.opentok.android:opentok-android-sdk:2.25.2

the apk size is larger than 100MB so I use "analyze apk" from android studio and it shows libopentok.so is about 40MB(in x86_64)

I enabled ProGuard but no help.

Can the sdk size be reduced?

libopentok_so

@goncalocostamendes
Copy link
Contributor

@ntustzeus unfortunately there is no workaround to reduce the SDK size. I would ask you to remain with v2.25.1 if possible where the size is around half of v2.25.2.

The size has increased on v2.25.2 because we introduced Media Processor functionalities such as Background Blur and Background Replacement. Since the size is an issue for multiple costumers, we are working on providing Media Processor functionalities as a plugin that can be added to the SDK or not.

We're tracking this internally: https://jira.vonage.com/browse/VPF-499. We expect to have it solved by Q1 2024.

@AlexMoumou
Copy link

@goncalocostamendes Is there a workaround for the size right now in the latest versions? v2.25.1 is unusable because it has the issue with the disconnect events being late 20-30secs causing our users sessions to get messed up if they log out and log in to quickly?

@goncalocostamendes
Copy link
Contributor

@AlexMoumou the solution to this problem is on the final stage of development. It should be released in the following weeks

@omaiborodahj
Copy link

@goncalocostamendes any updates on this issue?

@goncalocostamendes
Copy link
Contributor

@emartynov @ntustzeus @wlTrunks @AlexMoumou @omaiborodahj @danmajercak the decoupling was already implemented and merged into the main branch. In the next release 2.28.0, planned to be done by late May, a second lib OpenTok_Transformers will be opt-in. The OpenTok lib size returned to its normal size

@Panda-ref
Copy link

@goncalocostamendes

Is there a known release date for 2.28.0? Is it still late May?

@ntustzeus
Copy link

2024/6/3, it seems no new release note from offical site.

the issue is nothing about new feature but just to revert a clean version, how can it take 10 months and not completed?
Hope the new version will be well optimized before release.

2024-06-03_110446-vonage-android-sdk

@goncalocostamendes
Copy link
Contributor

@v-kpheng can you confirm 2.28.0 is comming up and if possible an ETA

@v-kpheng
Copy link
Contributor

v-kpheng commented Jun 3, 2024

@goncalocostamendes, ETA slipped to end of June. Sorry.

@Panda-ref
Copy link

@v-kpheng Any updates?

@goncalocostamendes
Copy link
Contributor

goncalocostamendes commented Jul 4, 2024

Android SDK 2.27.2 was already released and now two different libraries exist.

The latest Maven version is available at https://central.sonatype.com/artifact/com.vonage/client-sdk-video

Our Android lib with video conference capabilities you are familiar - com.vonage:client-sdk-video:2.27.2
A new opt-in library to support Video and Audio Transformers for features such as Background Blur and Noise Suppression - com.vonage:client-sdk-video-transformers:2.27.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants