feat(policy): allow ListRegisteredResources to return ActionAttributeValues on RegisteredResourceValues #2469
Conversation
…Values on RegisteredResourceValues
github-actions
bot
added
comp:db
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jakedoublev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enriching the data returned by the ListRegisteredResources API. The primary goal is to provide more comprehensive policy-related information by including detailed action attribute values directly within the registered resource values, making the API response more complete for consumers.
Highlights
- API Enhancement: I've enhanced the
ListRegisteredResourcesAPI endpoint to includeActionAttributeValueswithin theRegisteredResourceValuesthat are returned. Previously, these nested details were not available directly in the list response. - Database Query Update: The underlying SQL query for
ListRegisteredResourceshas been updated to perform aLEFT JOIN LATERALto aggregate and include theactionandattribute_valuedetails for each registered resource value, ensuring this data is part of the JSON output. - Integration Test Coverage: A new integration test has been added to verify that
ListRegisteredResourcescorrectly returnsRegisteredResourceValuescontaining the associatedActionAttributeValuesas expected.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A list of resources, once plain, Now brings rich details again. With actions and traits, Policy dictates, No data is left in the rain.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The code changes introduce the ability to return ActionAttributeValues on RegisteredResourceValues when listing registered resources. The changes include a new test case and modifications to the SQL query to fetch the action attribute values.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
| FROM registered_resources r | ||
| CROSS JOIN counted | ||
| LEFT JOIN registered_resource_values v ON v.registered_resource_id = r.id | ||
| -- Build a JSON array of action/attribute pairs for each resource value |
jakedoublev
merged commit 7cac3b0
into
DSPX-895-auth-svc-rr-get-decision-support
Proposed Changes
Checklist
Testing Instructions