Skip to content

feat(authz): authz v2 GetBulkDecision #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2025
Merged

feat(authz): authz v2 GetBulkDecision #2448

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2d8ba98
feat(authz): authz v2 GetBulkDecision
jakedoublev Jun 16, 2025
9725db3
get bulk decision
jakedoublev Jun 16, 2025
1ba406f
unit tests of bulk protovalidate implementation
jakedoublev Jun 16, 2025
aa63400
reduce test flakiness
jakedoublev Jun 16, 2025
898ac9b
lint fix
jakedoublev Jun 16, 2025
249b0db
Merge remote-tracking branch 'origin' into feat/DSPX-1207-bulk
jakedoublev Jun 17, 2025
c1ab9b7
pr suggestions
jakedoublev Jun 17, 2025
37a4d38
lint fixes
jakedoublev Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions service/authorization/v2/authorization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,10 @@ func (as *Service) GetDecision(ctx context.Context, req *connect.Request[authzV2

decisions, permitted, err := pdp.GetDecision(ctx, entityIdentifier, action, []*authzV2.Resource{resource})
if err != nil {
// TODO: any bad request errors that aren't 500s?
as.logger.ErrorContext(ctx, "failed to get decision", slog.String("error", err.Error()))
if errors.Is(err, access.ErrFQNNotFound) || errors.Is(err, access.ErrDefinitionNotFound) {
return nil, connect.NewError(connect.CodeNotFound, err)
}
return nil, connect.NewError(connect.CodeInternal, err)
}
resp, err := rollupSingleResourceDecision(permitted, decisions)
Expand Down Expand Up @@ -158,8 +160,10 @@ func (as *Service) GetDecisionMultiResource(ctx context.Context, req *connect.Re

decisions, allPermitted, err := pdp.GetDecision(ctx, entityIdentifier, action, resources)
if err != nil {
// TODO: any bad request errors that aren't 500s?
as.logger.ErrorContext(ctx, "failed to get decision", slog.String("error", err.Error()))
if errors.Is(err, access.ErrFQNNotFound) || errors.Is(err, access.ErrDefinitionNotFound) {
return nil, connect.NewError(connect.CodeNotFound, err)
}
return nil, connect.NewError(connect.CodeInternal, err)
}

Expand Down
2 changes: 1 addition & 1 deletion service/internal/access/v2/evaluate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (

var (
ErrInvalidResource = errors.New("access: invalid resource")
ErrFQNNotFound = errors.New("access: attribute value FQN not found in memory")
ErrFQNNotFound = errors.New("access: attribute value FQN not found")
ErrDefinitionNotFound = errors.New("access: definition not found for FQN")
ErrFailedEvaluation = errors.New("access: failed to evaluate definition")
ErrMissingRequiredSpecifiedRule = errors.New("access: AttributeDefinition rule cannot be unspecified")
Expand Down
2 changes: 1 addition & 1 deletion service/internal/access/v2/pdp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (p *PolicyDecisionPoint) GetDecision(

attributeAndValue, ok := p.allEntitleableAttributesByValueFQN[valueFQN]
if !ok {
return nil, fmt.Errorf("resource value FQN not found in memory [%s]: %w", valueFQN, ErrInvalidResource)
return nil, fmt.Errorf("%w [%s]: %w", ErrFQNNotFound, valueFQN, ErrInvalidResource)
}

decisionableAttributes[valueFQN] = attributeAndValue
Expand Down
Loading