fix(core): Let default basic keymanager work again #2858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally require all keys loaded from the policy db to have this configured. A lot of existing keys won't have this set, and any keys imported via the command line tool's import don't have it set yet
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Contributor
sujankota
previously approved these changes
Oct 30, 2025
cshamrick
previously approved these changes
Oct 30, 2025
dmihalcik-virtru
removed this pull request from the merge queue due to a manual request
dmihalcik-virtru
dismissed stale reviews from cshamrick and sujankota
via
709d23d
sujankota
approved these changes
Oct 30, 2025
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Contributor
Contributor
|
Successfully created backport PR for |
opentdf-automation bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
### Proposed Changes The recent change to us the ProviderConfig accidentally makes that field required for all keys already loaded from the policy db. Since most (all) existing keys won't have this set, and any keys imported via the command line tool's import don't have it set, we should keep the old behavior ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions (cherry picked from commit fb0b99d)
opentdf-automation bot
added a commit
that referenced
this pull request
Oct 30, 2025
### Proposed Changes The recent change to us the ProviderConfig accidentally makes that field required for all keys already loaded from the policy db. Since most (all) existing keys won't have this set, and any keys imported via the command line tool's import don't have it set, we should keep the old behavior ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions (cherry picked from commit fb0b99d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The recent change to us the ProviderConfig accidentally makes that field required for all keys already loaded from the policy db. Since most (all) existing keys won't have this set, and any keys imported via the command line tool's import don't have it set, we should keep the old behavior
Checklist
Testing Instructions