fix(core): deprecate policy WithValue selector not utilized by RPC

[jakedoublev]

Proposed Changes

• This proto field has not been utilized by the service RPC in some time, so we can deprecate it in consumer code.

Checklist

• I have added or updated unit tests
• I have added or updated integration tests (if appropriate)
• I have added or updated documentation

Testing Instructions

[gemini-code-assist]

Summary of Changes

Hello @jakedoublev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a targeted cleanup of the codebase by deprecating and removing a specific field, WithValue, from policy.AttributeValueSelector that is no longer used by the service's RPC. The changes involve systematically eliminating this unused parameter from various GetAttributeValuesByFqnsRequest calls throughout the application, including core SDK components, service implementations, and associated integration tests. This effort aims to reduce technical debt, improve code clarity, and ensure that the codebase accurately reflects current operational requirements.

Highlights

• Deprecation of Unused Field: The WithValue selector within policy.AttributeValueSelector has been deprecated as it is no longer utilized by the service's RPC.
• Codebase Cleanup: Removed the now-unused WithValue field from all calls to attributes.GetAttributeValuesByFqnsRequest across the SDK, service logic, and integration tests.
• Improved Code Clarity: Streamlined the GetAttributeValuesByFqnsRequest calls by removing a redundant parameter, enhancing readability and maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Unused code removed, Cleaner paths for RPC, System breathes anew.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the usage of the deprecated WithValue selector from GetAttributeValuesByFqnsRequest across the codebase. The changes are consistent and correct, cleaning up unused code as preparation for its eventual removal from the protobuf definition. The implementation confirms that this field was not being used by the service RPC. The changes look good and improve code clarity by removing dead code.

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	160.831375ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	100.557152ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	350.303273ms
Throughput	285.47 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	38.435112958s
Average Latency	382.778963ms
Throughput	130.09 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	26.556790235s
Average Latency	264.505722ms
Throughput	188.28 requests/second

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	170.776555ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	124.210621ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	360.228664ms
Throughput	277.60 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.998712571s
Average Latency	398.394034ms
Throughput	125.00 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	27.992006837s
Average Latency	278.887895ms
Throughput	178.62 requests/second