Commit de9a76e
authored
fix(kas): Ensure root key is not logged. (#2918)
### Proposed Changes
1.) Modify the `KasConfig` object to redact the `root_key`
2.) Modify the `ServiceConfig` object to check for the existence of
`root_key`, if present redact it.
Logs redacted:
1.) At startup:
<img width="2437" height="82" alt="Screenshot 2025-11-19 at 8 28 18 AM"
src="https://github.com/user-attachments/assets/abe29f91-a84c-43ca-86a1-1832175fa0e2"
/>
2.) Update hook
<img width="2447" height="104" alt="Screenshot 2025-11-19 at 8 26 13 AM"
src="https://github.com/user-attachments/assets/7aff9a9e-38b5-48b6-a562-0ee3ca5c230e"
/>
3.) Startup - Invalid Config
<img width="2435" height="105" alt="Screenshot 2025-11-19 at 8 24 30 AM"
src="https://github.com/user-attachments/assets/634c227c-3d01-4908-b3d3-05759a9cf756"
/>
### Checklist
- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation
### Testing Instructions1 parent 182b463 commit de9a76e
2 files changed
+77
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
138 | 176 | | |
139 | 177 | | |
140 | 178 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
27 | 66 | | |
28 | 67 | | |
29 | 68 | | |
| |||
0 commit comments