simplify.

Author: c-r33d

service/policy/db/attribute_values.go

@@ -101,13 +101,10 @@ func (c PolicyDBClient) GetAttributeValue(ctx context.Context, identifier any) (
 		}
 	}
 
-	obligations := make([]*policy.Obligation, 0)
-	if av.Obligations != nil {
-		obligations, err = unmarshalObligations(av.Obligations)
-		if err != nil {
-			c.logger.ErrorContext(ctx, "could not unmarshal obligations", slog.String("error", err.Error()))
-			return nil, err
-		}
+	obligations, err := unmarshalObligations(av.Obligations)
+	if err != nil {
+		c.logger.ErrorContext(ctx, "could not unmarshal obligations", slog.String("error", err.Error()))
+		return nil, err
 	}
 
 	return &policy.Value{

service/policy/db/utils.go

@@ -162,7 +162,7 @@ func unmarshalObligationTrigger(triggerJSON []byte) (*policy.ObligationTrigger,
 
 func unmarshalObligations(obligationsJSON []byte) ([]*policy.Obligation, error) {
 	if obligationsJSON == nil {
-		return nil, nil
+		return make([]*policy.Obligation, 0), nil
 	}
 
 	raw := []json.RawMessage{}