Merge remote-tracking branch 'origin/make-dpop-optional' into make-dpop-optional

Author: mkleene

Dockerfile

@@ -1,4 +1,4 @@
-FROM --platform=$BUILDPLATFORM cgr.dev/chainguard/go:latest AS builder
+FROM cgr.dev/chainguard/go:latest AS builder
 ARG TARGETOS TARGETARCH
 
 WORKDIR /app

sdk/README.md

@@ -3,20 +3,34 @@
 A Go implementation of the OpenTDF protocol, and access library for services
 included in the Data Security Platform.
 
+Note: if you are consuming the SDK as a submodule you may need to add replace directives as follows:
+
+```go
+replace (
+  github.com/opentdf/platform/service => ./opentdf/service
+	github.com/opentdf/platform/lib/fixtures => ./opentdf/lib/fixtures
+	github.com/opentdf/platform/protocol/go => ./opentdf/protocol/go
+	github.com/opentdf/platform/lib/ocrypto => ./opentdf/lib/ocrypto
+	github.com/opentdf/platform/sdk => ./opentdf/sdk
+	github.com/opentdf/platform/service => ./opentdf/service
+)
+```
+
 ## Quick Start of the Go SDK
 
 ```go
 package main
 
-import bytes
-import io
-import os
-import strings
+import "fmt"
+import "bytes"
+import "io"
+import "os"
+import "strings"
 import "github.com/opentdf/platform/sdk"
 
 
 func main() {
-  s := sdk.New(
+  s, _ := sdk.New(
     sdk.WithAuth(mtls.NewGRPCAuthorizer(creds) /* or OIDC or whatever */),
     sdk.WithDataSecurityConfig(/* attribute schemas, kas multi-attribute mapping */),
   )

service/internal/auth/config.go

@@ -10,7 +10,7 @@ type Config struct {
 
 // AuthNConfig is the configuration need for the platform to validate tokens
 type AuthNConfig struct {
-	AllowNoDPoP       bool   `yaml:"allowNoDPoP" json:"allowNoDPoP" default:"true"`
+	AllowNoDPoP       bool   `yaml:"allowNoDPoP" json:"allowNoDPoP"`
 	Issuer            string `yaml:"issuer" json:"issuer"`
 	Audience          string `yaml:"audience" json:"audience"`
 	OIDCConfiguration `yaml:"-" json:"-"`

service/pkg/server/start_test.go

@@ -132,6 +132,5 @@ func Test_Start_When_Extra_Service_Registered_Expect_Response(t *testing.T) {
 	respBody, err := io.ReadAll(resp.Body)
 
 	require.NoError(t, err)
-	// FIXME: either by adding paths that do not require authentication or by writing our own auth token
 	assert.Equal(t, "hello from test service!", string(respBody))
 }