Skip to content

fix(core): improve readability of TDF methods #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix(core): improve readability of TDF methods #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/handlers/tdf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type TDFInspect struct {
UnencryptedMetadata []byte
}

func (h Handler) EncryptBytes(tdfType string, b []byte, values []string, mimeType string, kasUrlPath string, ecdsaBinding bool, assertions string) (*bytes.Buffer, error) {
func (h Handler) EncryptBytes(tdfType string, unencrypted []byte, attrValues []string, mimeType string, kasUrlPath string, ecdsaBinding bool, assertions string) (*bytes.Buffer, error) {
var encrypted []byte
enc := bytes.NewBuffer(encrypted)

Expand All @@ -44,7 +44,7 @@ func (h Handler) EncryptBytes(tdfType string, b []byte, values []string, mimeTyp
}

opts := []sdk.TDFOption{
sdk.WithDataAttributes(values...),
sdk.WithDataAttributes(attrValues...),
sdk.WithKasInformation(sdk.KASInfo{
URL: h.platformEndpoint + kasUrlPath,
}),
Expand All @@ -60,7 +60,7 @@ func (h Handler) EncryptBytes(tdfType string, b []byte, values []string, mimeTyp
opts = append(opts, sdk.WithAssertions(assertionConfigs...))
}

_, err := h.sdk.CreateTDF(enc, bytes.NewReader(b), opts...)
_, err := h.sdk.CreateTDF(enc, bytes.NewReader(unencrypted), opts...)
return enc, err

// Encrypt the data as a Nano TDF
Expand All @@ -74,15 +74,15 @@ func (h Handler) EncryptBytes(tdfType string, b []byte, values []string, mimeTyp
return nil, err
}
// set the attributes
if err = nanoTDFConfig.SetAttributes(values); err != nil {
if err = nanoTDFConfig.SetAttributes(attrValues); err != nil {
return nil, err
}
// enable ECDSA policy binding
if ecdsaBinding {
nanoTDFConfig.EnableECDSAPolicyBinding()
}
// create the nano TDF
if _, err = h.sdk.CreateNanoTDF(enc, bytes.NewReader(b), *nanoTDFConfig); err != nil {
if _, err = h.sdk.CreateNanoTDF(enc, bytes.NewReader(unencrypted), *nanoTDFConfig); err != nil {
return nil, err
}
return enc, nil
Expand Down
Loading