Skip to content

fix(core): values list should properly render table output #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrschumacher merged 1 commit into from
Jul 6, 2024
Merged

fix(core): values list should properly render table output #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cmd/policy-attributeValues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ import (

// TODO: add metadata to outputs once [https://github.com/opentdf/otdfctl/issues/73] is addressed

var (
policy_attributeValuesCmd *cobra.Command
)
var policy_attributeValuesCmd *cobra.Command

func policy_createAttributeValue(cmd *cobra.Command, args []string) {
flagHelper := cli.NewFlagHelper(cmd)
Expand Down Expand Up @@ -66,7 +64,7 @@ func policy_listAttributeValue(cmd *cobra.Command, args []string) {
}
t := cli.NewTable(
cli.NewUUIDColumn(),
table.NewColumn("fqn", "Fqn", 16),
table.NewColumn("fqn", "Fqn", 37),
table.NewColumn("members", "Members", 16),
table.NewColumn("active", "Active", 16),
table.NewColumn("labels", "Labels", 16),
Expand All @@ -86,6 +84,7 @@ func policy_listAttributeValue(cmd *cobra.Command, args []string) {
"updated_at": v.Metadata["Updated At"],
}))
}
t = t.WithRows(rows)
HandleSuccess(cmd, "", t, vals)
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/cli/sdkHelpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ func GetSimpleAttribute(a *policy.Attribute) SimpleAttribute {

func GetSimpleAttributeValue(v *policy.Value) SimpleAttributeValue {
memberIds := []string{}
for _, m := range v.Members {
memberIds = append(memberIds, m.Id)
for _, m := range v.GetMembers() {
memberIds = append(memberIds, m.GetId())
}
return SimpleAttributeValue{
Id: v.Id,
FQN: v.Fqn,
Id: v.GetId(),
FQN: v.GetFqn(),
Members: memberIds,
Active: strconv.FormatBool(v.Active.GetValue()),
Metadata: ConstructMetadata(v.GetMetadata()),
Expand Down