fix(main): Update flaky subject mapping tests

[c-r33d]

1.) Update tests to never have an unmapped scs so it doesn't get pruned by parallel tests. scs tests prune

[gemini-code-assist]

Summary of Changes

Hello @c-r33d, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability and reliability of the end-to-end test suite. It specifically addresses a flaky subject mapping update operation by introducing a retry mechanism, ensuring that transient issues do not cause test failures. Additionally, it refines how subject condition sets are created and validated within a test, improving the robustness of these test cases.

Highlights

• Flaky Test Fix: Implemented a retry mechanism for the subject mapping update operation in the E2E tests to mitigate flakiness, allowing up to 3 attempts with a 1-second delay.
• Subject Condition Set Creation Refinement: Modified an E2E test to create a new Subject Condition Set directly from a JSON definition (--subject-condition-set-new) rather than referencing a pre-existing ID, and added explicit assertions for the ID of the newly created set.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a retry mechanism to an e2e test to handle eventual consistency issues, which is a good approach for flaky tests. The changes are confined to e2e/subject-mapping.bats. My feedback includes a suggestion to improve the shell script logic by leveraging jq's capabilities for a more robust and idiomatic check.

[github-actions]

X-Test Results

✅ js-v0.4.34
✅ java-v0.4.34
bats-test-results
✅ go-v0.4.34
✅ js-main
✅ java-main
✅ go-main

[github-actions]

X-Test Results

✅ js-v0.4.34
✅ java-v0.4.34
bats-test-results
✅ go-v0.4.34
✅ js-main
✅ java-main
✅ go-main

[github-actions]

X-Test Results

✅ java-v0.4.34
✅ js-v0.4.34
bats-test-results
test-cases-mapping-report
✅ go-v0.4.34
✅ js-main
✅ java-main
✅ go-main

[github-actions]

X-Test Results

✅ java-v0.4.34
✅ js-v0.4.34
bats-test-results
✅ go-v0.4.34
✅ js-main
✅ java-main
✅ go-main

[github-actions]

X-Test Results

✅ java-v0.4.34
✅ js-v0.4.34
bats-test-results
test-cases-mapping-report
✅ go-v0.4.34
✅ js-main
✅ java-main
✅ go-main