feat(core): add ecdsa-binding encrypt flag #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmihalcik-virtru
commented
Sep 4, 2024
dmihalcik-virtru
commented
- this enables the optional 'ecdsa binding' feature in nanotdf containers
- this enables the optional 'ecdsa binding' feature in nanotdf containers
dmihalcik-virtru
changed the title
pflynn-virtru
previously approved these changes
Sep 4, 2024
Contributor
|
This looks good. Can we please add an e2e test for this functionality to verify? https://github.com/opentdf/otdfctl/blob/main/tests/encrypt-decrypt.bats#L50 |
jrschumacher
requested changes
Sep 5, 2024
Member
jrschumacher
left a comment
jrschumacher
left a comment
There was a problem hiding this comment.
Tests failing due to missing flag string
Co-authored-by: Ryan Schumacher <[email protected]>
jrschumacher
approved these changes
Sep 5, 2024
jakedoublev
pushed a commit
that referenced
this pull request
Sep 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.13.0](v0.12.2...v0.13.0) (2024-09-12) ### Features * add cli test mode and profile tests ([#313](#313)) ([e0bc183](e0bc183)) * **ci:** make e2e test workflow reusable ([#365](#365)) ([d94408c](d94408c)) * **ci:** namespaces e2e tests and test suite improvements ([#351](#351)) ([ce28555](ce28555)) * **ci:** reusable platform composite action in e2e tests ([#369](#369)) ([f7d5a1c](f7d5a1c)) * **core:** add ecdsa-binding encrypt flag ([#360](#360)) ([8702ec0](8702ec0)) * **core:** adds missing long manual output docs ([#362](#362)) ([8e1390f](8e1390f)), closes [#359](#359) * **core:** kas-grants list ([#346](#346)) ([7f51282](7f51282)), closes [#253](#253) ### Bug Fixes * **ci:** e2e workflow should be fully reusable ([#368](#368)) ([cc1e2b9](cc1e2b9)) * **ci:** enhance lint config and resolve all lint issues ([#363](#363)) ([5c1dbf1](5c1dbf1)) * **core:** GOOS, error message fixes ([#378](#378)) ([623a82a](623a82a)), closes [#380](#380) * **core:** metadata rendering cleanup ([#293](#293)) ([ed21f81](ed21f81)) * **core:** wire attribute value FQNs to encrypt ([#370](#370)) ([21f9b80](21f9b80)) * refactor to support varying print output ([#350](#350)) ([d6932f3](d6932f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.