fix: create new http client to ignore tls verification #324
+95
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jrschumacher @jakedoublev Not sure if we need this in other places as well. |
Close opentdf#340 Close opentdf#316
This was
linked to
issues
Aug 27, 2024
jakedoublev
reviewed
Aug 27, 2024
jakedoublev
previously approved these changes
Aug 27, 2024
jakedoublev
approved these changes
Aug 27, 2024
jrschumacher
pushed a commit
that referenced
this pull request
Aug 27, 2024
🤖 I have created a release *beep* *boop* --- ## [0.12.2](v0.12.1...v0.12.2) (2024-08-27) ### Bug Fixes * **core:** improve KASR docs and add spellcheck GHA to pipeline ([#323](#323)) ([a77cf30](a77cf30)), closes [#335](#335) [#337](#337) * create new http client to ignore tls verification ([#324](#324)) ([4d4afb7](4d4afb7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With otdfctl leveraging zitadel module for oidc outside the scope of the sdk otdfctl needs to create a custom http client to ignore tls verification.