Skip to content

Conversation

@jakedoublev
Copy link
Contributor

Resolves #197

@jakedoublev jakedoublev requested a review from a team as a code owner August 6, 2024 15:18
@jrschumacher
Copy link
Member

Does this need to be a uniform interface when processing JSON data?

@jrschumacher
Copy link
Member

Or just SCS because it uses Json?

@jakedoublev
Copy link
Contributor Author

It looks like the CLI currently reads only Subject Condition Sets and client credentials from JSON optionally as a flag value or a file. In each case we unmarshal differently into values (the former with json.RawMessage and protojson and the latter via just json), so I don't know how much value a common interface would give at this time. Please let me know if you disagree, though.

@jrschumacher jrschumacher merged commit ebc16ea into main Aug 10, 2024
@jrschumacher jrschumacher deleted the feat/scs-from-file branch August 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't reference file when updating condition sets

3 participants