Skip to content

Conversation

@elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Jul 17, 2024

Add to e2e workflow -- clone platform, spin it up, do basic round trip
Sets up bats structure

@elizabethhealy elizabethhealy changed the title feat(ci): Add e2e workflow setup feat(ci): Add e2e workflow setup + bats Jul 18, 2024
@elizabethhealy elizabethhealy marked this pull request as ready for review July 18, 2024 15:07
@elizabethhealy elizabethhealy requested a review from a team as a code owner July 18, 2024 15:07
@jakedoublev
Copy link
Contributor

You should be able to add a test run against this branch by updating this list with your branch name: https://github.com/opentdf/otdfctl/pull/234/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR6

@elizabethhealy
Copy link
Member Author

elizabethhealy commented Jul 18, 2024

You should be able to add a test run against this branch by updating this list with your branch name: https://github.com/opentdf/otdfctl/pull/234/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR6

@jakedoublev its running already in the e2e tests run for this PR here https://github.com/opentdf/otdfctl/actions/runs/9993925545/job/27622496655?pr=234

or do you mean like adding more tests in PRs against this branch?

@jakedoublev
Copy link
Contributor

You should be able to add a test run against this branch by updating this list with your branch name: #234 (files)

@jakedoublev its running already in the e2e tests run for this PR here opentdf/otdfctl/actions/runs/9993925545/job/27622496655?pr=234

or do you mean like adding more tests in PRs against this branch?

Oh awesome, I didn't realize that and forgot we had empty e2e tests before, even though it's right there in the diff. :)

@jakedoublev
Copy link
Contributor

I think the last thing to add is a testing section of the readme then this should be good for approval

@jakedoublev jakedoublev merged commit ca6ce5a into main Jul 19, 2024
@jakedoublev jakedoublev deleted the add-e2e-test-workflow branch July 19, 2024 16:20
@jakedoublev jakedoublev mentioned this pull request Aug 5, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants