Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider integrating local-storage-full warning message into save button #8950

Open
tyrasd opened this issue Feb 4, 2022 · 2 comments
Open
Labels
considering Not Actionable - still considering if this is something we want

Comments

@tyrasd
Copy link
Member

tyrasd commented Feb 4, 2022

From #8942 (reply in thread):

It could make sense to show the warning for a full local storage not in the status bar (rendered similar as the OSM API unavailable message), but somehow integrate it into the save button. There are some reasons behind it:

  • The warning can take up too much screen estate while mapping
  • The save button is already used as an indicator when one should save. There could be an additional step in the states of the button (e.g. indicated by a ⚠️ symbol) to show that saving is really recommended when local storage is full
  • The bottom status bar should be reserved for proper "error" states, e.g. when the OSM API is not available
@tyrasd tyrasd added the considering Not Actionable - still considering if this is something we want label Feb 4, 2022
@CorruptComputer
Copy link
Contributor

Just wanted to add this info here in case its useful, apparently you can get 50mb of storage by using the IndexedDB API instead of localStorage: https://stackoverflow.com/a/37277426

Would it be a possibility for iD to use this to store the changes?

@bhousel
Copy link
Member

bhousel commented Jun 14, 2022

Would it be a possibility for iD to use this to store the changes?

Yep thats #3239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want
Projects
None yet
Development

No branches or pull requests

3 participants