Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if a brand tag is used in a non-matching country/region #6989

Open
doublah opened this issue Oct 29, 2019 · 4 comments
Open

Warn if a brand tag is used in a non-matching country/region #6989

doublah opened this issue Oct 29, 2019 · 4 comments
Labels
validation An issue with the validation or Q/A code

Comments

@doublah
Copy link

doublah commented Oct 29, 2019

With osmlab/name-suggestion-index#3135, there are now 3 entries for Travelodge worldwide.
However all previously suggested to upgrade buildings won't suggest the appropriate brand to upgrade to, and won't suggest to remove the bad old brand tags.

Examples: https://www.openstreetmap.org/way/214628168, https://www.openstreetmap.org/way/521226316

We need to:

  • suggest removal of tags if no longer valid (e.g. if a countryCode is no longer valid for the tagged object/brand removed from name-suggestion-index).
  • suggest correct tags for names with multiple brands operating under said name, if brands don't overlap in operating areas, this would also affect brands like Londis, with 2 brands operating under that name, but with no countryCode overlap, so it's safe to suggest brand tags.
@quincylvania
Copy link
Collaborator

quincylvania commented Oct 29, 2019

@doublah Cool idea. We're doing #6941 next which will give iD a much better sense of countries. That will unblock this issue along with #6479 and #6513.

Also related: #6523, which involves removing brands that no longer exist according to NSI.

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Oct 29, 2019
@bhousel
Copy link
Member

bhousel commented Nov 19, 2019

yea this is #6523

@bhousel bhousel closed this as completed Nov 19, 2019
@quincylvania
Copy link
Collaborator

@bhousel I see #6523 as just about dissolved brands and this issue about brands that don't match the country but they are pretty similar.

@bhousel
Copy link
Member

bhousel commented Nov 20, 2019

I see #6523 as just about dissolved brands and this issue about brands that don't match the country but they are pretty similar.

oh sorry, let me reopen and rename..
The country-coder work I've done in osm-community-index can also work for name-suggestion-index, to let us get much more accurate about where brands operate.

@bhousel bhousel reopened this Nov 20, 2019
@bhousel bhousel changed the title Realize when a brand tags are no longer valid. Warn if a brand tag is used in a non-matching country/region Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants