This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
Allow billy to handle newly-defined Imago boundary sets #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ | |||
| from piston.handler import BaseHandler, HandlerMetaClass | |||
|
|
|||
| AT_LARGE = ['At-Large', 'Chairman'] | |||
| ACTIVE_BOUNDARY_SETS = settings.BOUNDARY_SERVICE_SETS.split(",") | |||
| ACTIVE_BOUNDARY_SETS_RE = settings.BOUNDARY_SERVICE_SETS | |||
|
Testing this locally now. |
|
Confirmed working, including the Mississippi fix. |
|
Hmm, except NH floterials aren't loading now. They're in the OCD response, though. Let me look into this some more, and I'll tie it up with you later. |
|
@mileswwatkins I don't know if this is to stale to be useful to you, or if we should keep it around for later |
|
Ideally when we turn on the OCD API, we'd also make a jump to supporting this newer, date-sensitive nomenclature of boundaries. So, the question is, do we need Billy to also support these new-style boundaries? I guess so? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be string-parsing OCD IDs anyway.~the great @paultag