diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 56ad6d089..2c1c5fbd7 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -31,6 +31,7 @@ repos: entry: make args: ['crd-schema-check'] pass_filenames: false + verbose: true - repo: https://github.com/pre-commit/pre-commit-hooks rev: v4.4.0 diff --git a/Makefile b/Makefile index 427fdc11d..f516280da 100644 --- a/Makefile +++ b/Makefile @@ -481,4 +481,4 @@ webhook-cleanup: PHONY: crd-schema-check crd-schema-check: manifests INSTALL_DIR=$(LOCALBIN) CRD_SCHEMA_CHECKER_VERSION=release-4.16 hack/build-crd-schema-checker.sh - INSTALL_DIR=$(LOCALBIN) BRANCH=$(BRANCH) hack/crd-schema-checker.sh + INSTALL_DIR=$(LOCALBIN) BASE_REF="$${PULL_BASE_SHA:-$(BRANCH)}" hack/crd-schema-checker.sh diff --git a/apis/bases/core.openstack.org_openstackcontrolplanes.yaml b/apis/bases/core.openstack.org_openstackcontrolplanes.yaml index 669280c40..09eb2afed 100644 --- a/apis/bases/core.openstack.org_openstackcontrolplanes.yaml +++ b/apis/bases/core.openstack.org_openstackcontrolplanes.yaml @@ -10879,6 +10879,8 @@ spec: format: int32 minimum: 0 type: integer + foo: + type: integer nodeSelector: additionalProperties: type: string @@ -14696,6 +14698,8 @@ spec: type: string type: object type: array + required: + - foo type: object type: object type: object diff --git a/apis/core/v1beta1/openstackcontrolplane_types.go b/apis/core/v1beta1/openstackcontrolplane_types.go index 6add4f982..b46408cdb 100644 --- a/apis/core/v1beta1/openstackcontrolplane_types.go +++ b/apis/core/v1beta1/openstackcontrolplane_types.go @@ -511,6 +511,9 @@ type RabbitmqTemplate struct { // +operator-sdk:csv:customresourcedefinitions:type=spec // NodeSelector to target subset of worker nodes running this service NodeSelector *map[string]string `json:"nodeSelector,omitempty"` + + // +kubebuilder:validation:Required + Foo int `json:"foo"` } // OvnSection defines the desired state of OVN services diff --git a/config/crd/bases/core.openstack.org_openstackcontrolplanes.yaml b/config/crd/bases/core.openstack.org_openstackcontrolplanes.yaml index 669280c40..09eb2afed 100644 --- a/config/crd/bases/core.openstack.org_openstackcontrolplanes.yaml +++ b/config/crd/bases/core.openstack.org_openstackcontrolplanes.yaml @@ -10879,6 +10879,8 @@ spec: format: int32 minimum: 0 type: integer + foo: + type: integer nodeSelector: additionalProperties: type: string @@ -14696,6 +14698,8 @@ spec: type: string type: object type: array + required: + - foo type: object type: object type: object diff --git a/hack/crd-schema-checker.sh b/hack/crd-schema-checker.sh index 284e688cc..c5f4a4c94 100755 --- a/hack/crd-schema-checker.sh +++ b/hack/crd-schema-checker.sh @@ -11,10 +11,9 @@ function cleanup { trap cleanup EXIT - for crd in config/crd/bases/*.yaml; do mkdir -p "$(dirname "$TMP_DIR/$crd")" - git show "origin/$BRANCH:$crd" > "$TMP_DIR/$crd" + git show "$BASE_REF:$crd" > "$TMP_DIR/$crd" $CHECKER check-manifests \ --existing-crd-filename="$TMP_DIR/$crd" \ --new-crd-filename="$crd"