Skip to content

Commit 379093d

Browse files
Merge pull request #1043 from coreydaley/clean_up_imports
Cleaning up imports
2 parents 927f64a + adfc3ee commit 379093d

File tree

11 files changed

+25
-21
lines changed

11 files changed

+25
-21
lines changed

pkg/cmd/cli/cli.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ import (
66
"runtime"
77
"strings"
88

9-
utillog "github.com/openshift/source-to-image/pkg/util/log"
109
"github.com/spf13/cobra"
1110

1211
"github.com/openshift/source-to-image/pkg/api"
1312
"github.com/openshift/source-to-image/pkg/cmd/cli/cmd"
1413
cmdutil "github.com/openshift/source-to-image/pkg/cmd/cli/util"
1514
"github.com/openshift/source-to-image/pkg/docker"
15+
utillog "github.com/openshift/source-to-image/pkg/util/log"
1616
)
1717

1818
// log is a placeholder until the builders pass an output stream down

pkg/cmd/cli/cmd/build.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import (
44
"fmt"
55
"os"
66

7-
"github.com/openshift/source-to-image/pkg/scm/git"
8-
utillog "github.com/openshift/source-to-image/pkg/util/log"
97
"github.com/spf13/cobra"
108

119
"github.com/openshift/source-to-image/pkg/api"
@@ -18,8 +16,10 @@ import (
1816
"github.com/openshift/source-to-image/pkg/docker"
1917
s2ierr "github.com/openshift/source-to-image/pkg/errors"
2018
"github.com/openshift/source-to-image/pkg/run"
19+
"github.com/openshift/source-to-image/pkg/scm/git"
2120
"github.com/openshift/source-to-image/pkg/tar"
2221
"github.com/openshift/source-to-image/pkg/util"
22+
utillog "github.com/openshift/source-to-image/pkg/util/log"
2323
"github.com/openshift/source-to-image/pkg/version"
2424
)
2525

pkg/cmd/cli/cmd/generate.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@ package cmd
22

33
import (
44
"context"
5+
"strings"
6+
57
"github.com/containers/image/v5/transports/alltransports"
68
"github.com/containers/image/v5/types"
79
"github.com/spf13/cobra"
8-
"strings"
910

1011
"github.com/openshift/source-to-image/pkg/api"
1112
"github.com/openshift/source-to-image/pkg/api/constants"

pkg/cmd/cli/util/util.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@ import (
55
"os"
66
"path/filepath"
77

8+
"github.com/spf13/cobra"
9+
"github.com/spf13/pflag"
10+
811
log "k8s.io/klog"
912

1013
"github.com/openshift/source-to-image/pkg/api"
11-
"github.com/spf13/cobra"
12-
"github.com/spf13/pflag"
1314
)
1415

1516
// AddCommonFlags adds the common flags for usage, build and rebuild commands

pkg/config/config.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@ import (
77
"regexp"
88
"strings"
99

10+
"github.com/spf13/cobra"
11+
"github.com/spf13/pflag"
12+
1013
"github.com/openshift/source-to-image/pkg/api"
1114
"github.com/openshift/source-to-image/pkg/scm/git"
1215
utillog "github.com/openshift/source-to-image/pkg/util/log"
13-
"github.com/spf13/cobra"
14-
"github.com/spf13/pflag"
1516
)
1617

1718
var log = utillog.StderrLog

pkg/docker/docker_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ import (
1010
"strings"
1111
"testing"
1212

13+
dockertypes "github.com/docker/docker/api/types"
14+
dockercontainer "github.com/docker/docker/api/types/container"
15+
dockerstrslice "github.com/docker/docker/api/types/strslice"
16+
1317
"github.com/openshift/source-to-image/pkg/api/constants"
1418
dockertest "github.com/openshift/source-to-image/pkg/docker/test"
1519
"github.com/openshift/source-to-image/pkg/errors"
1620
testfs "github.com/openshift/source-to-image/pkg/test/fs"
17-
18-
dockertypes "github.com/docker/docker/api/types"
19-
dockercontainer "github.com/docker/docker/api/types/container"
20-
dockerstrslice "github.com/docker/docker/api/types/strslice"
2121
)
2222

2323
func TestContainerName(t *testing.T) {

pkg/docker/util_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"testing"
66

77
cliconfig "github.com/docker/docker/cli/config"
8+
89
"github.com/openshift/source-to-image/pkg/api/constants"
910
"github.com/openshift/source-to-image/pkg/util/user"
1011
)

pkg/tar/tar.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@ import (
1111
"strings"
1212
"time"
1313

14-
"github.com/openshift/source-to-image/pkg/util/fs"
15-
utillog "github.com/openshift/source-to-image/pkg/util/log"
16-
1714
s2ierr "github.com/openshift/source-to-image/pkg/errors"
1815
"github.com/openshift/source-to-image/pkg/util"
16+
"github.com/openshift/source-to-image/pkg/util/fs"
17+
utillog "github.com/openshift/source-to-image/pkg/util/log"
1918
)
2019

2120
var log = utillog.StderrLog

pkg/util/fs/fs.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ import (
1212
"sync"
1313
"time"
1414

15-
utillog "github.com/openshift/source-to-image/pkg/util/log"
16-
1715
s2ierr "github.com/openshift/source-to-image/pkg/errors"
16+
utillog "github.com/openshift/source-to-image/pkg/util/log"
1817
)
1918

2019
var log = utillog.StderrLog

test/generate_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package test
22

33
import (
4-
"github.com/openshift/source-to-image/pkg/cmd/cli/cmd"
54
"testing"
5+
6+
"github.com/openshift/source-to-image/pkg/cmd/cli/cmd"
67
)
78

89
func TestGenerate_canonizeBuilderImageArg(t *testing.T) {

test/integration/docker/integration_test.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,13 @@ import (
1616
"testing"
1717
"time"
1818

19-
"k8s.io/klog"
20-
2119
dockertypes "github.com/docker/docker/api/types"
2220
dockercontainer "github.com/docker/docker/api/types/container"
2321
dockerapi "github.com/docker/docker/client"
22+
"golang.org/x/net/context"
23+
24+
"k8s.io/klog"
25+
2426
"github.com/openshift/source-to-image/pkg/api"
2527
"github.com/openshift/source-to-image/pkg/build"
2628
"github.com/openshift/source-to-image/pkg/build/strategies"
@@ -30,7 +32,6 @@ import (
3032
"github.com/openshift/source-to-image/pkg/tar"
3133
"github.com/openshift/source-to-image/pkg/util"
3234
"github.com/openshift/source-to-image/pkg/util/fs"
33-
"golang.org/x/net/context"
3435
)
3536

3637
const (

0 commit comments

Comments
 (0)