-
Notifications
You must be signed in to change notification settings - Fork 2k
Move CI test script to repo #68280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI test script to repo #68280
Conversation
Having it in openshift/release is inconvenient, as it often needs to be modifies. It should just rely on the Makefile target like the install step. For now that target doesn't exist, but it will be added in. Doesn't matter because the CI doesn't work anyway. rh-ecosystem-edge/assisted-chat#126
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/pj-rehearse ack |
|
@omertuc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@omertuc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, omertuc, oourfali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Having it in openshift/release is inconvenient, as it often needs to be modifies. It should just rely on the Makefile target like the install step. For now that target doesn't exist, but it will be added in. Doesn't matter because the CI doesn't work anyway. rh-ecosystem-edge/assisted-chat#126
Having it in openshift/release is inconvenient, as it often needs to be modifies. It should just rely on the Makefile target like the install step. For now that target doesn't exist, but it will be added in. Doesn't matter because the CI doesn't work anyway. rh-ecosystem-edge/assisted-chat#126
Having it in openshift/release is inconvenient, as it often needs to be modifies. It should just rely on the Makefile target like the install step. For now that target doesn't exist, but it will be added in. Doesn't matter because the CI doesn't work anyway. rh-ecosystem-edge/assisted-chat#126
Having it in openshift/release is inconvenient, as it often needs to be modifies. It should just rely on the Makefile target like the install step. For now that target doesn't exist, but it will be added in. Doesn't matter because the CI doesn't work anyway. rh-ecosystem-edge/assisted-chat#126
Having it in openshift/release is inconvenient, as it often needs to be modified. It should just rely on the Makefile target like the install step. For now that target doesn't exist, but it will be added in rh-ecosystem-edge/assisted-chat#126. Doesn't matter because the CI doesn't work anyway.