Skip to content

Conversation

@omertuc
Copy link
Contributor

@omertuc omertuc commented Aug 19, 2025

Having it in openshift/release is inconvenient, as it often needs to be modified. It should just rely on the Makefile target like the install step. For now that target doesn't exist, but it will be added in rh-ecosystem-edge/assisted-chat#126. Doesn't matter because the CI doesn't work anyway.

Having it in openshift/release is inconvenient, as it often needs to be
modifies. It should just rely on the Makefile target like the install
step. For now that target doesn't exist, but it will be added in.
Doesn't matter because the CI doesn't work anyway.

rh-ecosystem-edge/assisted-chat#126
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@openshift-ci openshift-ci bot requested review from carbonin and eranco74 August 19, 2025 18:31
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@omertuc: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rh-ecosystem-edge-assisted-chat-main-eval-test rh-ecosystem-edge/assisted-chat presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@oourfali
Copy link

/lgtm

@omertuc
Copy link
Contributor Author

omertuc commented Aug 19, 2025

/pj-rehearse ack

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@openshift-ci-robot
Copy link
Contributor

@omertuc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@omertuc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eranco74
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, omertuc, oourfali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e5402dd into openshift:master Aug 19, 2025
10 checks passed
JslYoon pushed a commit to JslYoon/openshift-release that referenced this pull request Aug 25, 2025
Having it in openshift/release is inconvenient, as it often needs to be
modifies. It should just rely on the Makefile target like the install
step. For now that target doesn't exist, but it will be added in.
Doesn't matter because the CI doesn't work anyway.

rh-ecosystem-edge/assisted-chat#126
tbuskey pushed a commit to tbuskey/release that referenced this pull request Aug 26, 2025
Having it in openshift/release is inconvenient, as it often needs to be
modifies. It should just rely on the Makefile target like the install
step. For now that target doesn't exist, but it will be added in.
Doesn't matter because the CI doesn't work anyway.

rh-ecosystem-edge/assisted-chat#126
etmurasaki pushed a commit to etmurasaki/release that referenced this pull request Sep 3, 2025
Having it in openshift/release is inconvenient, as it often needs to be
modifies. It should just rely on the Makefile target like the install
step. For now that target doesn't exist, but it will be added in.
Doesn't matter because the CI doesn't work anyway.

rh-ecosystem-edge/assisted-chat#126
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 9, 2025
Having it in openshift/release is inconvenient, as it often needs to be
modifies. It should just rely on the Makefile target like the install
step. For now that target doesn't exist, but it will be added in.
Doesn't matter because the CI doesn't work anyway.

rh-ecosystem-edge/assisted-chat#126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants