Skip to content

Conversation

@hdefazio
Copy link
Contributor

@hdefazio hdefazio commented Aug 19, 2025

RHOAIENG-32595
Upgrade odh-model-controller to use go 1.24

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@openshift-ci openshift-ci bot requested review from Jooho and pierDipi August 19, 2025 03:10
@hdefazio hdefazio changed the title Upgrade to go 1.24 Upgrade odh-model-controller to go 1.24 Aug 19, 2025
@Jooho
Copy link
Contributor

Jooho commented Aug 19, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@Jooho: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hdefazio
Copy link
Contributor Author

I've contacted #forum-ocp-testplatform to create the missing image

@hdefazio
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@hdefazio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@hdefazio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-odh-model-controller-main-images opendatahub-io/odh-model-controller presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-model-controller-main-pr-image-mirror opendatahub-io/odh-model-controller presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-model-controller-main-unit opendatahub-io/odh-model-controller presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-model-controller-incubating-images opendatahub-io/odh-model-controller presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-model-controller-incubating-pr-image-mirror opendatahub-io/odh-model-controller presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-model-controller-incubating-unit opendatahub-io/odh-model-controller presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@hdefazio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Jooho
Copy link
Contributor

Jooho commented Aug 19, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hdefazio, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9e81d0a into openshift:master Aug 19, 2025
18 checks passed
JslYoon pushed a commit to JslYoon/openshift-release that referenced this pull request Aug 25, 2025
* Upgrade to go 1.24

* Update go image tag to new tag format
tbuskey pushed a commit to tbuskey/release that referenced this pull request Aug 26, 2025
* Upgrade to go 1.24

* Update go image tag to new tag format
etmurasaki pushed a commit to etmurasaki/release that referenced this pull request Sep 3, 2025
* Upgrade to go 1.24

* Update go image tag to new tag format
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 9, 2025
* Upgrade to go 1.24

* Update go image tag to new tag format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants